Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and add tips from notion doc #1053

Merged
merged 8 commits into from
Mar 4, 2025
Merged

Review and add tips from notion doc #1053

merged 8 commits into from
Mar 4, 2025

Conversation

J2-D2-3PO
Copy link
Contributor

@J2-D2-3PO J2-D2-3PO commented Jan 31, 2025

Pulls relevant info from best practices docs linked in https://wandb.atlassian.net/browse/DOCS-838, and adds it to various areas in the docs. Left over from the Jan docs team 🐛 🔨

Confirm that tests pass and this change is ready for review:

  • Local hugo serve
  • Local vale ./content

@J2-D2-3PO J2-D2-3PO self-assigned this Jan 31, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8d7185
Status: ✅  Deploy successful!
Preview URL: https://0b1b9bb4.docodile.pages.dev
Branch Preview URL: https://docs-838.docodile.pages.dev

View logs

@J2-D2-3PO J2-D2-3PO marked this pull request as ready for review February 6, 2025 22:02
@J2-D2-3PO J2-D2-3PO requested a review from a team as a code owner February 6, 2025 22:02
@mdlinville mdlinville self-requested a review February 6, 2025 22:09
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copyedit suggestions to use more active text avoid stating opinions about what is easy or difficult. If a suggestion doesn't help, please ignore it. I'll go ahead and approve so that you won't be blocked either way.

@J2-D2-3PO
Copy link
Contributor Author

Some copyedit suggestions to use more active text avoid stating opinions about what is easy or difficult. If a suggestion doesn't help, please ignore it. I'll go ahead and approve so that you won't be blocked either way.

Thanks I think I addressed most everything

@J2-D2-3PO J2-D2-3PO merged commit 90cd93e into main Mar 4, 2025
5 checks passed
@J2-D2-3PO J2-D2-3PO deleted the DOCS-838 branch March 4, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants