Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set gorilla oidc secret #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Set gorilla oidc secret #110

wants to merge 3 commits into from
+6 −1

Conversation

adityachoudhari26
Copy link
Member

No description provided.

zacharyblasczyk
zacharyblasczyk approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@zacharyblasczyk zacharyblasczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried that not everyone is setting .Values.sso.clientSecret, but better to make this change now rather than later.

@venky-wandb
Copy link
Contributor

Where did we land with merging this change? Was there any concern with adding this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyblasczyk zacharyblasczyk zacharyblasczyk approved these changes

@nfoucha nfoucha nfoucha approved these changes

@gls4 gls4 Awaiting requested review from gls4

@jsbroks jsbroks Awaiting requested review from jsbroks jsbroks is a code owner

@vanpelt vanpelt Awaiting requested review from vanpelt vanpelt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityachoudhari26 @venky-wandb @nfoucha @zacharyblasczyk