Skip to content

Commit

Permalink
Revert "fix: Allow for inbound-cidrs for the ALB"
Browse files Browse the repository at this point in the history
This reverts commit 3cb558b.
  • Loading branch information
zacharyblasczyk committed Dec 2, 2023
1 parent e8c9296 commit 81d4616
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
4 changes: 1 addition & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ module "wandb" {

annotations = {
"alb.ingress.kubernetes.io/load-balancer-name" = "${var.namespace}-alb-k8s"
"alb.ingress.kubernetes.io/inbound-cidrs" = <<-EOF
'${join("\\,", var.allowed_inbound_cidr)}'
EOF
"alb.ingress.kubernetes.io/inbound-cidrs" = "0.0.0.0/0"
"alb.ingress.kubernetes.io/scheme" = "internet-facing"
"alb.ingress.kubernetes.io/target-type" = "ip"
"alb.ingress.kubernetes.io/listen-ports" = "[{\\\"HTTPS\\\": 443}]"
Expand Down
4 changes: 2 additions & 2 deletions modules/app_eks/external_dns/external_dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ resource "helm_release" "external_dns" {
}

set {
name = "domainFilters[0]"
name = "domainFilters[0]"
value = var.fqdn
}

set {
name = "serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
value = aws_iam_role.default.arn
}
}
}
2 changes: 1 addition & 1 deletion modules/app_eks/lb_controller/controller.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ resource "helm_release" "aws_load_balancer_controller" {
repository = "https://aws.github.io/eks-charts"
chart = "aws-load-balancer-controller"
namespace = "kube-system"
version = "1.6.2"
version = "1.6.1"

set {
name = "clusterName"
Expand Down
2 changes: 1 addition & 1 deletion modules/app_eks/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ output "autoscaling_group_names" {

output "node_role" {
value = aws_iam_role.node
}
}
1 change: 1 addition & 0 deletions outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,4 @@ output "url" {
value = local.url
description = "The URL to the W&B application"
}

0 comments on commit 81d4616

Please sign in to comment.