Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Init operator #154

Merged
merged 32 commits into from
Jan 8, 2024
Merged

feat!: Init operator #154

merged 32 commits into from
Jan 8, 2024

Conversation

jsbroks
Copy link
Member

@jsbroks jsbroks commented Nov 15, 2023 •
edited
Loading

Operator deploys our system in mutiple microservices

@jsbroks jsbroks requested a review from gls4 as a code owner November 15, 2023 18:50
@jsbroks jsbroks requested a review from a team November 15, 2023 18:50
jsbroks
jsbroks commented Nov 15, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
jsbroks
jsbroks commented Nov 15, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@zacharyblasczyk zacharyblasczyk changed the title Init operator feat: Init operator Dec 1, 2023
gls4
gls4 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gls4
gls4 suggested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy. So we don't want this written as a module like this -- this needs to be in the root directory in a single file.

@jsbroks
Copy link
Member Author

jsbroks commented Dec 18, 2023

@gls4 Why not? We do this for filestorage

@jsbroks
Copy link
Member Author

jsbroks commented Dec 18, 2023 •
edited
Loading

We have also already started rolling this out so it would require terraform surgery

@jsbroks
Copy link
Member Author

jsbroks commented Dec 18, 2023

If anything it should be a submodule under app_eks

@jsbroks jsbroks closed this Dec 18, 2023
@jsbroks jsbroks reopened this Dec 18, 2023
gls4
gls4 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's proceed for now. I may iterate on this later, but let's get things rolled out.

modules/efs/main.tf Outdated Show resolved Hide resolved
gls4
gls4 previously requested changes Dec 18, 2023
View reviewed changes
modules/app_eks/efs.tf Show resolved Hide resolved
@zacharyblasczyk zacharyblasczyk changed the title feat: Init operator feat!: Init operator Jan 8, 2024
@jsbroks jsbroks merged commit 95def33 into main Jan 8, 2024
8 checks passed
@jsbroks jsbroks deleted the operator branch January 8, 2024 15:28
jsbroks pushed a commit that referenced this pull request Jan 8, 2024
@semantic-release-bot
chore(release): version 4.0.0 [skip ci]
a9aab67 
## [4.0.0](v3.4.2...v4.0.0) (2024-01-08)

### ⚠ BREAKING CHANGES

* Init operator (#154)

### Features

* Init operator ([#154](#154)) ([95def33](95def33))
@jsbroks
Copy link
Member Author

jsbroks commented Jan 8, 2024

This PR is included in version 4.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyblasczyk zacharyblasczyk zacharyblasczyk left review comments

@gls4 gls4 gls4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsbroks @gls4 @zacharyblasczyk