-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modernize build system #175
refactor: modernize build system #175
Conversation
- Modernize CMake configuration using CMakePresets.json - Integrate vcpkg package management as submodule - Switch to Visual Studio 2022 generator for Windows builds - Simplify and standardize build presets across platforms - Clean up GitHub Actions workflow configuration This change modernizes the build system with better cross-platform support. It introduces vcpkg for package management and uses CMakePresets.json for a more standardized build configuration approach.
##168 (comment)
-> New:
在更新到lukka/run-cmake@v10后,
PS: 没有将Windows同步使用 Ninja generator,是因为目前还存在一些没有排查出的错误,ci流程跑不通,排查清楚后可能会根据需要统一全平台的generator |
感谢!可以提 MR 直接merge到 master,这样可以跑 CI |
我之前那个编译流程在多个平台上做的确实比较 trick |
@@ -294,9 +305,11 @@ jobs: | |||
with: | |||
allow_failure: true | |||
files: "${{ github.workspace }}/../../_temp/macos/src/libsimple.dylib, ${{ github.workspace }}/../../_temp/macos/test/dict/jieba.dict.utf8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我当时这么写是因为各个平台上路径不一样
不知道现在新版的有没有什么方法能获取到这些编译产出
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外你也可以关注下最后 so 文件的大小,之前是在 5M 左右;如果大小没怎么变应该产出就没问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最近也在看 bazel 不过感觉跟 cmake 比也是差不多,c++ 的编译环境实在是太差了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我看一下路径的问题。
产出我昨天ci跑下来都在5M左右,应该没什么问题,我稍后再打开测试一下
This change modernizes the build system with better cross-platform support. It introduces vcpkg for package management and uses CMakePresets.json for a more standardized build configuration approach.