Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Low Pass Filter feature #361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Low Pass Filter feature #361

wants to merge 2 commits into from

Conversation

ChrisWu0000
Copy link

@ChrisWu0000 ChrisWu0000 commented Feb 25, 2025

Description

I added a low-pass filter feature to the Plot_Dash_Item, allowing users to filter out data points that exceed a configurable min/max threshold. This improves data visualization by removing outliers and unwanted noise.

This PR closes #336.

Developer Testing

Here's what I did to test my changes:

  • Enabled and disabled the low_pass_filter toggle to see if it affects the graph.
  • Set different min_threshold and max_threshold values and verified correct filtering.
  • Confirmed that out-of-range data points are ignored while valid points are plotted.
  • Checked dynamic updates, changing thresholds and graph should immediately affect incoming data.
  • If min_threshold > max_threshold, the values are swapped automatically.
  • When the filter is off, all points should be displayed as expected.

Reviewer Testing

Here's what you should do to quickly validate my changes:

  • Toggle the Low-Pass Filter ON/OFF and check if filtering applies correctly.
  • Set Min and Max Threshold values and verify that out-of-range data is removed.
  • Ensure that disabling the filter restores all data points.
  • Check UI behavior when modifying threshold values.

This change is Reviewable

@ChrisWu0000 ChrisWu0000 requested review from a team as code owners February 25, 2025 14:49
@ChrisWu0000 ChrisWu0000 changed the title C86wu Added Low Pass Filter feature Feb 25, 2025
@ChrisYx511
Copy link
Contributor

ChrisYx511 commented Mar 1, 2025

Hi! This seems right from my perspective, but I would consult with the electrical people to make sure that this is what they meant. You can ping @ Ash Lang on Slack in #electrical (or I can do it if you prefer) and we can talk more during meeting next week! I / @zangjiucheng will approve then.
Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request (NT)] - Low-Pass Filter for Dashboard Plot (Dashboard Sink)
2 participants