app/proc: Load real procedures and upgrade viz

[jacobdeery]

• Add a menu for opening a ProcLang file in the application (available
  with Ctrl-O)
• Add utility functions to the ProceduresEngine for loading a new suite
  and resetting
• Add visualization of ProcedureStep conditions/transitions
• Add a bunch of TODOs

The procedures pane will look like this for now:

We haven't merged #54 yet, so there's no pretty string representation, but once we get those in it will look a bit more concise.

---

This change is 

[wendi-yu]

Yeah looks good! I tried out loading the example proclang doc from the menu and moving through the steps, everything seems to work well (including the highlighting we talked about :0) Admittedly I don't have a ton of insight to offer on the Qt stuff though :)

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @CODE-TITAN, @jacobdeery, and @wendi-yu)

---

application/procedures_bridge.py, line 156 at r1 (raw file):

    @Slot()
    def stop(self):
        # TODO(jacob): Should this reset the plumbing engine as well?

I think it makes sense for it to reset the plumbing engine - if we didn't, we'd end up with the procedures reset and ready to work on a plumbing engine in a modified state. If we just wanted to do something custom to the current plumbing engine state I think it makes more sense to pause than to stop?

---

application/resources/ProceduresPane.qml, line 73 at r1 (raw file):

            width: proceduresList.width
            height: procedureColumn.height + 10
            color: ListView.isCurrentItem ? "#d8fff7" : (index % 2 == 0 ? "#f2f2f2" : "#f9f9f9")

Is there any way to name the colours more friendly-ily? It's a minor inconvenience since I'm pretty sure most editors give a sample colour anyways but just asking - maybe worth looking into if there's a way to globally assign names to theme colours or something, once UI becomes a thing that we care about more.

[jacobdeery]

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @CODE-TITAN and @wendi-yu)

---

application/procedures_bridge.py, line 156 at r1 (raw file):

Previously, wendi-yu (Wendi Yu) wrote…

I think it makes sense for it to reset the plumbing engine - if we didn't, we'd end up with the procedures reset and ready to work on a plumbing engine in a modified state. If we just wanted to do something custom to the current plumbing engine state I think it makes more sense to pause than to stop?

Yeah, I would tend to agree with that. I'll leave that for a future PR because right now there isn't a plumbing engine reset() method.

---

application/resources/ProceduresPane.qml, line 73 at r1 (raw file):

Previously, wendi-yu (Wendi Yu) wrote…

Is there any way to name the colours more friendly-ily? It's a minor inconvenience since I'm pretty sure most editors give a sample colour anyways but just asking - maybe worth looking into if there's a way to globally assign names to theme colours or something, once UI becomes a thing that we care about more.

I've turned these into properties instead of hardcoded inline strings. Pulling them out into a global theme will probably require a bit more work; I'll open an issue and leave that for a future PR.

[wendi-yu]

LGTM

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @CODE-TITAN and @wendi-yu)

---

application/procedures_bridge.py, line 156 at r1 (raw file):

Previously, jacobdeery (Jacob Deery) wrote…

Yeah, I would tend to agree with that. I'll leave that for a future PR because right now there isn't a plumbing engine reset() method.

Huh, I guess there isn't. Sounds like it could be a good first issue :0

---

application/resources/ProceduresPane.qml, line 73 at r1 (raw file):

Previously, jacobdeery (Jacob Deery) wrote…

I've turned these into properties instead of hardcoded inline strings. Pulling them out into a global theme will probably require a bit more work; I'll open an issue and leave that for a future PR.

Cool cool, I was just thinking about how tailwind does it (global JSON config file, iirc). Could be a cool new thing to implement later on, imo it definitely makes UI stuff cleaner and nicer to work with - but it'll definitely be more helpful if/when we have a decided UI with actual theme colours to implement and stuff :)

[jacobdeery]

Ready to go now that all of the other prerequisite PRs are in!

[wendi-yu]

Ah very cool I like it! I assume the newly rebased stuff was code reviewed. I can't step through the procedure loaded from example.proc when I run the application, not sure if that's expected? Looks good otherwise. It'll be really exciting once we connect this to loading in a plumbing engine system from PDL as well.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @CODE-TITAN, @jacobdeery, and @wendi-yu)

---

application/procedures_bridge.py, line 136 at r3 (raw file):

    @Slot()
    def loadProcedureSuite(self):
        # TODO(jacob): Make this menu remember the last file opened

Good first issue?

[jacobdeery]

I can't step through the procedure loaded from example.proc when I run the application, not sure if that's expected?

Discussed offline, expected behaviour for the procedure in question

It'll be really exciting once we connect this to loading in a plumbing engine system from PDL as well.

Stay tuned for #79!

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @CODE-TITAN and @wendi-yu)

---

application/procedures_bridge.py, line 136 at r3 (raw file):

Previously, wendi-yu (Wendi Yu) wrote…

Good first issue?

Wilco