Skip to content

Commit

Permalink
Upgrade Vite and other deps to resolve packaging issue (#1387)
Browse files Browse the repository at this point in the history
There was a bug in Vite 6.0.1
(vitejs/vite#18810) that was preventing NodeJS
libraries from being bundled in the main process. This meant that our
packaged app would refuse to run as it would be unable to find its Node
libraries.

This updates to Vite 6.0.2 to resolve this issue and also updates a few
other deps while we're at it.

Also removes the SASS modern-compiler config from our Vite config since
this is the default behavior in Vite 6.

closes #1373
  • Loading branch information
esimkowitz authored Dec 5, 2024
1 parent ea55904 commit 6400678
Show file tree
Hide file tree
Showing 4 changed files with 387 additions and 156 deletions.
4 changes: 2 additions & 2 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"eslint": "^9.16.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-mdx": "^3.1.5",
"prettier": "^3.4.1",
"prettier": "^3.4.2",
"prettier-plugin-jsdoc": "^1.3.0",
"prettier-plugin-organize-imports": "^4.1.0",
"remark-cli": "^12.0.1",
Expand All @@ -53,7 +53,7 @@
"remark-preset-lint-consistent": "^6.0.0",
"remark-preset-lint-recommended": "^7.0.0",
"typescript": "^5.7.2",
"typescript-eslint": "^8.16.0"
"typescript-eslint": "^8.17.0"
},
"resolutions": {
"path-to-regexp@npm:2.2.1": "^3",
Expand Down
7 changes: 0 additions & 7 deletions electron.vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ export default defineConfig({
"process.env.WS_NO_BUFFER_UTIL": "true",
"process.env.WS_NO_UTF_8_VALIDATE": "true",
},
css: {
preprocessorOptions: {
scss: {
api: "modern-compiler", // or "modern"
},
},
},
},
preload: {
root: ".",
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,31 +56,31 @@
"@types/uuid": "^10.0.0",
"@types/ws": "^8",
"@vitejs/plugin-react-swc": "^3.7.2",
"@vitest/coverage-istanbul": "^2.1.6",
"@vitest/coverage-istanbul": "^2.1.8",
"electron": "^33.2.0",
"electron-builder": "^25.1.8",
"electron-vite": "^2.3.0",
"eslint": "^9.16.0",
"eslint-config-prettier": "^9.1.0",
"prettier": "^3.4.1",
"prettier": "^3.4.2",
"prettier-plugin-jsdoc": "^1.3.0",
"prettier-plugin-organize-imports": "^4.1.0",
"rollup-plugin-flow": "^1.1.1",
"sass": "^1.81.0",
"sass": "^1.82.0",
"semver": "^7.6.3",
"storybook": "^8.4.6",
"storybook-dark-mode": "^4.0.2",
"ts-node": "^10.9.2",
"tslib": "^2.8.1",
"tsx": "^4.19.2",
"typescript": "^5.7.2",
"typescript-eslint": "^8.16.0",
"vite": "^6.0.1",
"typescript-eslint": "^8.17.0",
"vite": "^6.0.2",
"vite-plugin-image-optimizer": "^1.1.8",
"vite-plugin-static-copy": "^2.2.0",
"vite-plugin-svgr": "^4.3.0",
"vite-tsconfig-paths": "^5.1.3",
"vitest": "^2.1.6"
"vitest": "^2.1.8"
},
"dependencies": {
"@floating-ui/react": "^0.26.28",
Expand Down
Loading

0 comments on commit 6400678

Please sign in to comment.