This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
fixing deprecation for Rails 5 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngocbv
suggested changes
Nov 7, 2017
| ActionDispatch::Reloader.cleanup! | ||
| ActionDispatch::Reloader.prepare! | ||
| Rails.application.reloader.reload! | ||
| Rails.application.reloader.prepare! |
There was a problem hiding this comment.
I think it just Rails.application.reloader.reload!
There was a problem hiding this comment.
This fix works for me, including both reload! and prepare!. Of course, since this has not been merged yet so I had to manually change it in the local middleware.rb file. It is important to note that this only works in Rails 5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 is in it release candidate and this fix remove the deprecation messages when calling cleanup and prepare in the old way. It is not workable for Rails < 5 though and i am open for suggestion to make it work backwards.