Update fillAttribute to return parent result by default #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to v2.0.0 I was getting the following error when trying to save a resource that included a CKEditor field
It looks like this was caused by the addition of the return type. If there is no pending upload, then the method does not return, which is apparently a type error.
Being completely honest, I am not sure on the ramifications of my suggested change. I initially changed it to just return
null
, which fixed the error for me. Then I changed it to return the result ofparent::fillAttribute()
, which also works for me.Where my uncertainty comes in is when there are uploads to handle. We do not use the upload functionality so I can't easily test to make sure that still works as expected. Would be great if someone who does have it setup to do uploads could give this a test to make sure it works for them still.