update document

Signed-off-by: Ruihang Xia <[email protected]>
waynexia · Jun 7, 2024 · 34e8923 · 34e8923
1 parent f41263c
commit 34e8923
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/datafusion/common/src/scalar/mod.rs b/datafusion/common/src/scalar/mod.rs
@@ -4816,7 +4816,6 @@ mod tests {
                 TimestampNanosecond,
                 Some("UTC".into())
             ),
-            // TODO: add them back
             make_test_case!(i32_vals, IntervalYearMonthArray, IntervalYearMonth),
             make_test_case!(interval_dt_vals, IntervalDayTimeArray, IntervalDayTime),
             make_test_case!(

diff --git a/datafusion/optimizer/src/analyzer/type_coercion.rs b/datafusion/optimizer/src/analyzer/type_coercion.rs
@@ -811,7 +811,6 @@ mod test {
     use arrow::datatypes::DataType::Utf8;
     use arrow::datatypes::{DataType, Field, TimeUnit};
 
-    use arrow_buffer::IntervalDayTime;
     use datafusion_common::tree_node::{TransformedResult, TreeNode};
     use datafusion_common::{DFSchema, DFSchemaRef, Result, ScalarValue};
     use datafusion_expr::expr::{self, InSubquery, Like, ScalarFunction};
@@ -1085,7 +1084,7 @@ mod test {
     fn binary_op_date32_op_interval() -> Result<()> {
         // CAST(Utf8("1998-03-18") AS Date32) + IntervalDayTime("...")
         let expr = cast(lit("1998-03-18"), DataType::Date32)
-            + lit(ScalarValue::new_interval_dt(123,  456))
+            + lit(ScalarValue::new_interval_dt(123, 456));
         let empty = empty();
         let plan = LogicalPlan::Projection(Projection::try_new(vec![expr], empty)?);
         let expected =

diff --git a/datafusion/physical-plan/src/aggregates/mod.rs b/datafusion/physical-plan/src/aggregates/mod.rs
@@ -1484,6 +1484,7 @@ mod tests {
         ))];
 
         let task_ctx = if spill {
+            // set to an appropriate value to trigger spill
             new_spill_ctx(2, 1600)
         } else {
             Arc::new(TaskContext::default())
@@ -1545,8 +1546,8 @@ mod tests {
             input_schema,
         )?);
 
-        // enlarge memory limit in spill mode
         let task_ctx = if spill {
+            // enlarge memory limit to let the final aggregation finish
             new_spill_ctx(2, 2600)
         } else {
             task_ctx.clone()