Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to reproduce a ValueError when x500UniqueIdentifier is of type UTF8String #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vxgmichel
Copy link

@vxgmichel vxgmichel commented Oct 18, 2022

Add tests to reproduce issue #228

@vxgmichel vxgmichel changed the title Add tests to reproduce issue #228 Add tests to reproduce a ValueError when x500UniqueIdentifier is of type UTF8String Oct 18, 2022
@wbond
Copy link
Owner

wbond commented Aug 23, 2023

Could you rebase this on master?

@vxgmichel
Copy link
Author

Could you rebase this on master?

Sure, I allowed edits by maintainers 👍

@wbond
Copy link
Owner

wbond commented Aug 23, 2023

A few things:

  1. The code doesn't pass linting
  2. purest isn't used on this project
  3. The test harness from this project requires specifying a new test class in test_classes() of tests/__init__.py, so currently these tests aren't run, and why it wasn't obvious that pytest isn't supported

@vxgmichel
Copy link
Author

vxgmichel commented Aug 24, 2023

@wbond here you go, all your points should be addressed : 3758f73 :)

@vxgmichel
Copy link
Author

Thank you @wbond for fixing #268

And yes this is also a shameless ping for issue #228 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants