This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 800
Bump to v2 #67
Open
wdzeng
wants to merge
34
commits into
main
Choose a base branch
from
features/v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump to v2 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade dependencies and remove unused ones. Upgrade Node.js version to 20. Also update commands in package.json, and ESLint and prettier configurations. All unittests in v1 are removed. Removed VSCode devcontainer as it is no longer needed.
Removed unittests in CI/CD as they are not yet implemented.
The settings API is returning checking list with length 8. Not sure why but this violates with our spec.
We want that all logging messages be printed to stderr, and command results stdout, but `loglevel` outputs messages of `info` level to stdout, and there is no way to configure. Therefore implement our own logging functions. Also use `chalk` for printing colors.
Also remove dependency from API to logging utility.
Avoid depend on dom lib.
Use @commander-js/extra-typings for smarter type infer. Split error handling functions and cookie and verbosity utilities from cli/index.ts.
wdzeng
force-pushed
the
features/v2
branch
2 times, most recently
from
September 30, 2023 16:18
9a1ee2e
to
97f814e
Compare
Merge unittests.yml into publish.yml Only run building and tagging when pushing to main or dev branch, or when the workflow is triggered manually. Do not force pushing general version tag (vX.X.X). This help avoid to accidentally overriding existing tags.
Add a fake test script. This is because unittests are required when running CI/CD.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.