-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gt 1029 implement expand for openzaak api's when 1.11 openzaak is available #397
base: master
Are you sure you want to change the base?
Gt 1029 implement expand for openzaak api's when 1.11 openzaak is available #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the experimental api call that was intended (open-zaak/open-zaak#1664), but nonetheless useful! Having a seperate experimental adapter is not needed for this though.
Could you merge this with the normal version of geefLijstZaakdocumenten? Then add a DeploymentSpecifics property zaakbrug.zgw.zaken-api.version=1.2
. < 1.5 it should do the seperate getZaak call and getZaakInformatieObjecten. >= 1.5 it should do the getZaak with expand call.
For the experimental open-zaak/open-zaak#1664 ill make a seperate issue. It requires our development docker-compose openzaak version to be updated to 1.13 first though, but that seems to be more than a quick change.
This issue is new to me - Some miscommunication must have taken place at some point. Apologies for the confusion.
Will do the merge ASAP. |
src/main/configurations/Translate/Configuration_GeefLijstZaakdocumenten_Lv01.xml
Outdated
Show resolved
Hide resolved
src/main/configurations/Translate/Configuration_SoapEndpointRouter_BeantwoordVraag.xml
Outdated
Show resolved
Hide resolved
src/main/configurations/Translate/DeploymentSpecifics.properties
Outdated
Show resolved
Hide resolved
@@ -13,6 +13,12 @@ | |||
<Exit name="EXCEPTION" state="ERROR"/> | |||
</Exits> | |||
|
|||
<XmlIfPipe name="CheckApiVersion" xpathExpression="${zaakbrug.zgw.zaken-api.version} < 1.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you can reference a property like in the xpathExpression like this. Usually it is needed to reference the property in a param and then reference the param in the xpathExpression. Can you check if setting zaakbrug.zgw.zaken-api.version
>= 1.5 takes the correct forward?
Adds an alternative to GeefLijstZaakdocumenten. GeefLijstZaakdocumentenExpand will be used only when GeefLijstZaakdocumentenExpand_Lv01.Active == true.
Expand functionality can be used in more places if deemed necessary or advantageous.