Skip to content

Fix pod topology for jobs when cronJobs not exist. #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pod topology for jobs when cronJobs not exist. #3865

wants to merge 1 commit into from

Conversation

shabicheng
Copy link

Fixes #3864.

@bboreham
Copy link
Collaborator

Thanks for the PR - great spot!
Apologies for long delay in looking at it. I've kicked off the tests now so it should run the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl Awaiting requested review from fbarl

@qiell qiell Awaiting requested review from qiell

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weave Scope does not record the pod topology when there is only job(not cronjob) in kubernetes
2 participants
@shabicheng @bboreham