fix: rebuild should reset module.preOrderIndex #8413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
JSerFeng
force-pushed
the
fix/deterministic-hmr
branch
from
4eddc14 to
05dcb63
Compare
JSerFeng
requested review from
jerrykingxyz and
ahabhgk
and removed request for
jerrykingxyz
jerrykingxyz
previously approved these changes
Nov 12, 2024
JSerFeng
force-pushed
the
fix/deterministic-hmr
branch
2 times, most recently
from
52a1a7e to
cf7146c
Compare
|
there is also a similar bug with [contenthash] in ark subspace if you use content hash the hash rendered in the js files is missmatched to what stats emits and the files emitted on disk. Doesnt look related to this MR but seems to be from a similar possible cause? |
ahabhgk
previously approved these changes
Nov 13, 2024
Do we have a issue about it ? Sounds like the issue of incremental rebuild |
|
No i don't but I'll create one. Repo is bytedance internal so I will not share url publicly but can dm over lark. It's likely the same repo that you got the oncall about for this issue |
JSerFeng
force-pushed
the
fix/deterministic-hmr
branch
from
7bc1fd0 to
730692a
Compare
ahabhgk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #7031
mgm.preOrderIndex is set by buildChunkGraph, which is skipped during incremental rebuild.
When enable
newIncremental.buildChunkGraph, preOrderIndex is wrong by design, I'll refactor module.preOrderIndex soon in another PRChecklist