Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should have module-post-order-index when incremental build #8559

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Nov 28, 2024

Summary

build chunkGroup from cache should rebuild post/pre_order_index as well

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 0925dac
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674962c59549c30008767406
😎 Deploy Preview https://deploy-preview-8559--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #8559 will not alter performance

Comparing fix/incremental-chunk-group-post-order (0925dac) with main (deb10b9)

Summary

✅ 1 untouched benchmarks

@JSerFeng JSerFeng marked this pull request as ready for review November 28, 2024 11:00
ahabhgk
ahabhgk previously approved these changes Nov 28, 2024
@ahabhgk ahabhgk merged commit b1b596a into main Nov 29, 2024
32 checks passed
@ahabhgk ahabhgk deleted the fix/incremental-chunk-group-post-order branch November 29, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants