Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align DefinePlugin with #7108 in v0.x #8582

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Khez
Copy link

@Khez Khez commented Nov 29, 2024

Summary

Before #7108 there was a JSON.stringify() call in DefinePlugin

The change landed in https://github.com/web-infra-dev/rspack/releases/tag/v1.0.0-alpha.3

A couple of alpha versions do not require JSON.stringify()

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for rspack-v0 canceled.

Name Link
🔨 Latest commit 0f774f3
🔍 Latest deploy log https://app.netlify.com/sites/rspack-v0/deploys/674b98607abdd300083e8bbc

@Khez Khez changed the title Update v0 docs due to #7108 docs: Update v0 due to #7108 Dec 1, 2024
@github-actions github-actions bot added the release: document release: document related release(mr only) label Dec 1, 2024
@h-a-n-a h-a-n-a changed the title docs: Update v0 due to #7108 docs: align DefinePlugin with #7108 Dec 2, 2024
@h-a-n-a h-a-n-a changed the title docs: align DefinePlugin with #7108 docs: align DefinePlugin with #7108 in v0 Dec 2, 2024
@h-a-n-a h-a-n-a changed the title docs: align DefinePlugin with #7108 in v0 docs: align DefinePlugin with #7108 in v0.x Dec 2, 2024
@h-a-n-a h-a-n-a merged commit 6f046d1 into web-infra-dev:v0.x Dec 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: document release: document related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants