Allow custom properties in highlight pseudos #50379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271}
wpt-pr-bot
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the use case of custom properties
defined and used in the same rule for ::selection pseudos.
The use case arises from tooling, particularly Tailwind CSS,
and it caused a stable regression when Highlight Inheritance
was launched.
This change restores the original behavior in that highlight
pseudos can use custom properties defined in the highlight
itself. The custom properties are not inherited through the
highlight inheritance chain, so this change does not result in
confusion about the source of custom properties when Highlight
Inheritance is enabled: the properties still come from the
originating element and then the highlight pseudo itself, never
it's parent highlight.
CSS Spec PR: w3c/csswg-drafts#11528
Fixed: 381125910
Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1413271}