chore: Set AES128GCM as default encoding #222
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the default encryption encoding used in the
PushService
class fromAESGCM
toAES128GCM
.Rationale
While
AESGCM
is a newer encoding method, some modern browsers (e.g., Chrome, Edge) currently do not properly trigger service workers when receiving push notifications encoded withaesgcm
.By contrast,
aes128gcm
is widely supported and works reliably across all major browsers. This change ensures more consistent and reliable push notification delivery.Changes
send(Notification)
method inPushService
to useEncoding.AES128GCM
by default.Reference
##Notes