Skip to content

chore: Set AES128GCM as default encoding #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

swiftsjh02
Copy link
Contributor

@swiftsjh02 swiftsjh02 commented Jul 4, 2025

Summary

This PR changes the default encryption encoding used in the PushService class from AESGCM to AES128GCM.

Rationale

While AESGCM is a newer encoding method, some modern browsers (e.g., Chrome, Edge) currently do not properly trigger service workers when receiving push notifications encoded with aesgcm.

By contrast, aes128gcm is widely supported and works reliably across all major browsers. This change ensures more consistent and reliable push notification delivery.

Changes

  • Updated the send(Notification) method in PushService to use Encoding.AES128GCM by default.

Reference

##Notes

  • This is My First Contribution , Give any Opinion And Advice Freely.

@martijndwars
Copy link
Member

Thanks!

@martijndwars martijndwars merged commit d44851e into web-push-libs:master Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants