-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce own exception for assertions #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but we really need to put a nail on the coffin of exception overrides (still possible, really bad idea, and to be deprecated/removed).
Hm.. Interesting. I was sure we already did this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase this PR? |
ac7fe5d
to
6c9734f
Compare
Rebased. |
Thank you. Im 👍 |
Thank you |
May be helpful for catching only exceptions related to this package without the risk to catch another not related exceptions.
Ref #202