-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enums in error message #292
Add support for enums in error message #292
Conversation
God yes. I just bumped into this with Big +1 |
@gordinskiy recognizing that it has been a year... 😅 would you please rebase this? |
4dd4336
to
6a7c456
Compare
@shadowhand done |
@gordinskiy will you please add a test for this? It will need to be restricted to PHP versions that support Enum, of course. |
6a7c456
to
1ad20d0
Compare
Added test case for error message with enum in it. |
1ad20d0
to
8144e25
Compare
Ok, tests fails on old versions. if (PHP_VERSION_ID >= ENUM_INTRODUCTION_VERSION_ID) {
eval("
enum TestEnum
{
case CaseName;
}
");
} |
Rather than doing an |
316de36
to
137f51b
Compare
Updated test |
Thank you! |
Attempt to resolve #289