Replaced webmozart/path-util dependency with @internal Path::isAbsolute()
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsolute()` This imports sources from `webmozart/path-util`: since the license and authors are the same, no further license additions are necessary. Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/tests/PathTest.php Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/src/Path.php Fixes #59 Fixes #57
Ocramius
force-pushed
the
feature/remove-path-util-dependency
branch
from
9040891 to
e4553dd
Compare
|
Interesting: tests failing on windows due to the Really annoying overall - composer replacing everything is getting really painful. |
Ocramius
force-pushed
the
feature/remove-path-util-dependency
branch
from
e4553dd to
1d7dbf7
Compare
This is effectively re-introducing `Path::normalize()` from `webmozart/path-util`, but without the dependency requirement
This was referenced Apr 5, 2022
Ocramius
commented
Apr 5, 2022
Nek-
reviewed
Apr 5, 2022
|
Nice one. I'm fine with it, just some notice you may want to take a look at. But you can merge it. Thank you very much @Ocramius . |
|
I'll roll it as-is (in a release) for now: #28 should highlight these redundant casts in future, and we can adapt there 👍 |
|
Thanks for the review, @Nek-! |
|
Hi @Ocramius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports sources from
webmozart/path-util: since the licenseand authors are the same, no further license additions are necessary.
Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/tests/PathTest.php
Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/src/Path.php
Fixes #59
Fixes #57