Skip to content

Update module-methods.mdx #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adriancuadrado
Copy link

Added some clarifications about dynamic expressions in import() and magic comments.

Added some clarifications about dynamic expressions in import() and magic comments.
Copy link

vercel bot commented Jun 6, 2025

@adriancuadrado is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

linux-foundation-easycla bot commented Jun 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

alexander-akait
alexander-akait previously approved these changes Jun 6, 2025
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix lint action?

Fixed lint error:

```
MD013/line-length Line length [Expected: 600; Actual: 628]
```
@adriancuadrado
Copy link
Author

@alexander-akait Fixed!

The "Ensure PR / E2E test and link check (ubuntu-latest, lts/*) (pull_request)" job keeps failing but I don't know how to fix it.

ERROR in ./content/plugins/_html-minimizer-webpack-plugin.mdx
Module build failed (from ../node_modules/@mdx-js/loader/index.cjs):
_html-minimizer-webpack-plugin.mdx:571:1-571:79: Expected a closing tag for `<template>` (571:46-571:56) before the end of `paragraph`
 @ ./content/ lazy ^\.\/.*$ namespace object ./plugins/_html-minimizer-webpack-plugin.mdx
 @ ./App.jsx 5:20-47
 @ ./index.jsx 5:0-28 20:34-37
webpack 5.97.1 compiled with 1 error and 52 warnings in 30929 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: The process '/usr/local/bin/yarn' failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants