Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update webview, add linux ARM target #189

Merged
merged 25 commits into from
Jan 29, 2025

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Jan 26, 2025

This pr does:

  • update webview, its now based on gtk4 and webkitgtk 6
  • add linux arm target

The code was taken from webview-bun with modifications

fix #186 #176 #174

might f ix #175 as well but I'll have to test it

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jan 26, 2025

(please squash before merging)

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jan 26, 2025

I tested the builds and they seem to be generated correctly https://github.com/sigmaSd/webview_deno/releases

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jan 26, 2025

I made a working fork so its easier to test in practice

import { Webview } from "jsr:@sigmasd/[email protected]";

const html = `
  <html>
  <body>
    <h1>Hello from deno v${Deno.version.deno}</h1>
  </body>
  </html>
`;

const webview = new Webview();

webview.navigate(`data:text/html,${encodeURIComponent(html)}`);
webview.run();

Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

.github/workflows/build.yml Show resolved Hide resolved
@eliassjogreen eliassjogreen changed the title Update webview, add more targets feat: Update webview, add linux ARM target Jan 29, 2025
@eliassjogreen eliassjogreen merged commit 999191a into webview:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] update to new version of webview
2 participants