Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#36 Update to target multiple frameworks (netcoreapp3.1 and net5.0) #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#36 Update to target multiple frameworks (netcoreapp3.1 and net5.0) #39

wants to merge 3 commits into from

Conversation

mikkou-adafy
Copy link
Contributor

Resolves #36

  • Update library projects and tests to target both .NET Core 3.1 and .NET 5.0

@mikkou-adafy mikkou-adafy mentioned this pull request Jan 5, 2021
Open
3 tasks
@mikoskinen
Copy link
Contributor

Looking good. Could you add couple things:

  1. ASP.NET Core 5.0 sample. Functionality could be identical to the current WebApp-sample.
  2. Readme updated with a link to the new sample.

Thanks in advance :)

mikoskinen
mikoskinen requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mikoskinen mikoskinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample & Readme.

@mikkou-adafy
Copy link
Contributor Author

Added a .NET 5.0 Web API sample project and updated the README.

@mikkou-adafy mikkou-adafy changed the title Update to target multiple frameworks (netcoreapp3.1 and net5.0) #36 Update to target multiple frameworks (netcoreapp3.1 and net5.0) Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikoskinen mikoskinen mikoskinen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.NET 5 version
2 participants
@mikkou-adafy @mikoskinen