Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for showing tooltip on both axis #129

Open
wants to merge 502 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
502 commits
Select commit Hold shift + click to select a range
1f9023c
Merge branch 'feature/preserve-highlights'
dmitrym0 Jan 10, 2023
2eb85fc
Use ht module to structure highlight (+ unit tests).
dmitrym0 Jan 11, 2023
b38fa29
Remove stale code; add comments.
dmitrym0 Jan 11, 2023
dacde43
Add test utils file for common test functionality.
dmitrym0 Jan 11, 2023
3e0a573
Add a logging library.
dmitrym0 Jan 11, 2023
b21f493
Extract test session creation functionality out of org-noter-core-tes…
dmitrym0 Jan 11, 2023
226d89e
Move "mock" contents to utils.
dmitrym0 Jan 11, 2023
ed65eb4
Add end to end test for persiting pdf highlights.
dmitrym0 Jan 11, 2023
f3f5a05
Merge branch 'refactor-tests'
dmitrym0 Jan 11, 2023
5fb008d
tag some diffs with commit ID hashes
petermao Jan 12, 2023
5aa3019
README.org: add probable actions on deltas
petermao Jan 13, 2023
f42f4ad
update README.org w/ notes from 2023-01-13 meeting
petermao Jan 13, 2023
c6895fb
remove highlighting (will use dmitrym's development)
petermao Jan 13, 2023
dfab6ff
(pre-merge) in modules, change arg "major-mode" to "mode"
petermao Jan 14, 2023
d651139
(pre-merge) remove org-noter-pdf-check-location-property
petermao Jan 14, 2023
866c8c8
(pre-merge) update README.org with task status and mtg notes
petermao Jan 14, 2023
02e2e71
Merge commit (insert-note refactor)
petermao Jan 14, 2023
1ee0f97
Merge precise note fixup
petermao Jan 14, 2023
6baac75
Merge pre-meeting notes
petermao Jan 14, 2023
c68ad5f
remove test-mouse-event from noter-dev
petermao Jan 14, 2023
f62744c
Merge remote-tracking branch 'dmitrym0/master' into doc2
petermao Jan 14, 2023
be742dc
org-noter-pdf--parse-location breaks page notes
petermao Jan 14, 2023
c6578a4
update README.org with status of actions from mtg, fix typo
petermao Jan 14, 2023
55ae36c
Refactor highlighting functionality.
dmitrym0 Jan 14, 2023
7a7ac6f
update README.org - navigation bug
petermao Jan 14, 2023
aaaa34e
notes on debugging navigation problem
petermao Jan 14, 2023
b8364ee
bugfix: check-location-property was failing on 2D-precise-locations
petermao Jan 14, 2023
0b1428a
Merge navigation bugfix into dm/pm-merge
petermao Jan 14, 2023
291e7db
Merge branch 'feature/clean-up-hihglights'
dmitrym0 Jan 15, 2023
484e08b
update bug notes in README, + notes on multicolumn precise
petermao Jan 15, 2023
4bc485f
update keybindings in org-noter-dev.el
petermao Jan 15, 2023
1a705a0
+doc for org-noter-pdf-approx-location-cons, -merge chaff
petermao Jan 15, 2023
2747649
WIP multicolumn precise notes
petermao Jan 15, 2023
c9fb9e0
multi-column precise notes implemented
petermao Jan 15, 2023
df86b8f
Merge multi-column precise-notes into dm/pm-merge
petermao Jan 15, 2023
0fd569b
update README.org with notes on multi-column precise-notes
petermao Jan 15, 2023
395c9fa
bugfix: -insert-note, suppress QUOTE block with empty text selection
petermao Jan 15, 2023
49c54a4
Refactor org-noter-insert-note
petermao Jan 15, 2023
2f2755c
update documentation, remove org-noter-dev.el
petermao Jan 15, 2023
b1ab41f
Merge -insert-note refactor into dm/pm-merge
petermao Jan 16, 2023
6002ae1
Merge branch 'dm/pm-merge'
petermao Jan 16, 2023
8cc3d61
Merge remote-tracking branch 'peter-origin/master' into merge-with-peter
dmitrym0 Jan 16, 2023
7e4580d
Rename highlight-precise-note-hook to add-highlight-hook for clarity.
dmitrym0 Jan 16, 2023
18d0190
Correct the tests after merging with peter's branch.
dmitrym0 Jan 16, 2023
527a9e5
Call the correct hook when highlighting 🤦🏻‍♂️
dmitrym0 Jan 16, 2023
171b03d
Merge branch 'merge-with-peter'
dmitrym0 Jan 16, 2023
2712850
add HIGHLIGHT property to note when applicable
petermao Jan 16, 2023
93dad61
move highlighting utility funcs into utility section of code
petermao Jan 16, 2023
89a4ee1
move highlighting into org-noter-insert-note
petermao Jan 16, 2023
9bb9d29
Prefix (C-u) toggles -highlight-selected-text
petermao Jan 16, 2023
6360aa4
move -pdf-tools-edges-to-region from -core.el to modules/-pdf.el
petermao Jan 16, 2023
3dad1df
Move nov variables from -core to modules/..-nov
petermao Jan 16, 2023
0c762e0
Merge branch 'pm-dev': highlight in all modes, C-u toggle,...
petermao Jan 16, 2023
c0acbae
move text-selection related vars into User Variables section of code
petermao Jan 17, 2023
b9a7b99
move highlighting hooks into "Integration w/ other packages" section
petermao Jan 17, 2023
218e592
create subgroup org-noter-module-hooks for module hooks
petermao Jan 17, 2023
68b23b6
Update documentation to make it more new-user-friendly
petermao Jan 17, 2023
cd593f6
Merge documentation and code rearragement
petermao Jan 17, 2023
768f436
@dmitrym0: do we need dash just for -if-let*?
petermao Jan 17, 2023
385967f
Use selection as title and body for precise notes.
dmitrym0 Jan 17, 2023
d616249
Make the note title a part of completing read when taking a precise n…
dmitrym0 Jan 17, 2023
b2c7ea1
fix links in README.org
petermao Jan 18, 2023
7d94dc2
Merge branch: remove dash dependence
petermao Jan 18, 2023
9a70e29
Revert "Make the note title a part of completing read when taking a p…
dmitrym0 Jan 18, 2023
366ede4
Revert "Use selection as title and body for precise notes."
dmitrym0 Jan 18, 2023
d160a0f
Test custom behavior with org-noter--insert-heading advice.
dmitrym0 Jan 19, 2023
76c6b1d
Initial work on the location testing.
dmitrym0 Jan 21, 2023
98a5ddd
Remove debug output.
dmitrym0 Jan 21, 2023
cd3c86c
revert [49bc6ee], [f74263f] - remove all calls to org-collect-keywords
petermao Jan 21, 2023
031aa6b
documentation only: sync..-page-or-chapter
petermao Jan 21, 2023
56a45e0
fix sync-next-page-or-chapter navigation
petermao Jan 22, 2023
1466715
Merge branch -- fix laggy performance and next-page.. navigation
petermao Jan 22, 2023
0f507e0
update README.org (performance issue solved)
petermao Jan 22, 2023
591156e
Revert "documentation only: sync..-page-or-chapter"
petermao Jan 25, 2023
ed7bd32
bugfix: vertical doc/notes layout was not working
petermao Jan 25, 2023
8e32e69
make fore/back-ground colors of tooltip arrow customizable
petermao Jan 25, 2023
d7c4a5c
remove duplicated defcustoms
petermao Jan 25, 2023
b45b0d7
update README.org with proposed defcustom organization
petermao Jan 25, 2023
bdfed51
yet more additions to README.org (customizations)
petermao Jan 25, 2023
cd3071d
remove 'ht' from Cask dependencies
petermao Jan 25, 2023
4d4aaff
Merge: vertical layout bugfix + customize tooltip colors
petermao Jan 25, 2023
a7e61ba
Merge: documentation & cleanup
petermao Jan 25, 2023
601f08e
reformat (page H V) default title to use pagelabel etc.
petermao Jan 29, 2023
23deec9
update README: Features wishlist updated w/ new features list
petermao Jan 29, 2023
dd8ce95
update documentation on -pdf-convert-to-lcoation-cons for multicol
petermao Jan 30, 2023
7e9751a
README.org: add link of possible way forward w/ tooltip transparency
petermao Jan 30, 2023
af20a66
README.org: document some multicolumn issues
petermao Jan 30, 2023
f8d3780
prepare README.new.org for release
petermao Jan 30, 2023
66c88ac
bugfix: -pretty-print-location-for-title was leaving focus in doc
petermao Jan 30, 2023
aca6740
better multicolumn alg. use COLUMN_EDGES instead of NUM_COLUMNS
petermao Jan 31, 2023
8837d3d
Merge branch 'dev'
petermao Jan 31, 2023
0a584e8
notes for demo screencast, change keybinding for precise-no-Qs
petermao Feb 2, 2023
7c85115
new command to interactively set column edges for multicolumn PDFs
petermao Feb 2, 2023
973d7cc
make new defgroups for defcustom variables
petermao Feb 3, 2023
51496d5
nothing to see--purely cosmetic.
petermao Feb 3, 2023
780a8f5
-bug (navigation scrolling) +feature (vscroll buffer)
petermao Feb 4, 2023
97f4bd7
arrow positioning: move horizontal shift into --show-arrow
petermao Feb 4, 2023
78ce87c
Merge 'dev': group custom vars, navigation bugfix, arrow posn update
petermao Feb 5, 2023
f8c1943
Merge remote-tracking branch 'peter-origin/master' into merge-with-peter
dmitrym0 Feb 5, 2023
ee20853
Add a hook to handle org-noter--pretty-print-location-for-title
dmitrym0 Feb 6, 2023
64395d9
Disable extra tests for now.
dmitrym0 Feb 6, 2023
a7fdda4
This is part of the solution to the failing tests.
dmitrym0 Feb 6, 2023
aa89111
Actually commit "test disable" (>ლ)
dmitrym0 Feb 6, 2023
f66614e
Fix advice errors.
dmitrym0 Feb 6, 2023
ab14f89
Clean up tests.
dmitrym0 Feb 6, 2023
f4c318b
Merge branch 'merge-with-peter'
dmitrym0 Feb 6, 2023
439bb40
simplify package loading
petermao Feb 9, 2023
b636d35
+MobyDick.pdf and Notes.org for tests
petermao Feb 11, 2023
49cb962
update test to reflect package loading syntax
petermao Feb 12, 2023
3a5746a
flycheck: resolve 56 complaints
petermao Feb 12, 2023
cb35972
more changes to make flycheck happy. no functional changes.
petermao Feb 14, 2023
759edef
update README.new.org
petermao Feb 14, 2023
76adbc3
yet more capitulation to Flycheck
petermao Feb 14, 2023
0d93df4
tweak timing code in tests/Notes.org
petermao Feb 15, 2023
a2943dd
bugfix `org-noter--doc-get-page-slice' was not using width
petermao Feb 15, 2023
17dcb7b
remove unused variables
petermao Feb 16, 2023
1db8960
more flycheck fixes. 8 warnings and 59 info's to go in org-noter-core.el
petermao Feb 16, 2023
2644f24
org-noter-djvu: clear flycheck warnings
petermao Feb 19, 2023
2ccbf1c
in modules, check for base package before `require'
petermao Feb 19, 2023
2b75593
org-noter-nov: clear flycheck warnings
petermao Feb 19, 2023
a345b49
org-noter-pdf: clear flycheck warnings
petermao Feb 19, 2023
72b020f
org-noter-pdf: cleanup
petermao Feb 19, 2023
443c76d
org-noter-core: clean up documentation to placate flycheck
petermao Feb 19, 2023
db6dd9b
Merge dev: simplify loading, update tests
petermao Feb 20, 2023
a637927
Merge dev: bugfix, preparations for release
petermao Feb 20, 2023
46d81c2
Merge dev: more linting!
petermao Feb 20, 2023
82d99bc
Fix remaining flycheck complaints in -core.el
petermao Feb 25, 2023
91fff9a
README.new: fix broken link
petermao Mar 3, 2023
612e20c
update README.new documentation on multicolumn pdfs
petermao Mar 4, 2023
b4f3df6
new command: org-noter-start-from-dired
petermao Mar 6, 2023
1c323f6
Merge 'dev': update README, open noter sessions from dired
petermao Mar 7, 2023
74be976
-kill-frame-at-session-end nil was not working
petermao Mar 8, 2023
2424faf
update README.new.org: add stock vs new insert note documentation
petermao Mar 11, 2023
d7d3ed7
README shuffling: send README.org to docs/README-interim.org
petermao Mar 11, 2023
216187b
README.new.org -> README.org
petermao Mar 11, 2023
d108cc8
update README.org: redact "stock" and "refactored"
petermao Mar 11, 2023
e25c2e9
update org-noter(-core).el preambles (v 1.5.0)
petermao Mar 11, 2023
de072e4
-start-from-dired: bugfixes (clear flycheck warnings)
petermao Mar 11, 2023
254f4ab
Merge dev: README preparation, fix -kill-frame-..., -start-from-dired
petermao Mar 11, 2023
dac87ee
update maintainers list
petermao Mar 12, 2023
31011e1
make sure Dmitry is listed as a maintainer
petermao Mar 12, 2023
89221a4
;;<TAB> !?!
petermao Mar 13, 2023
7574998
melpa issue #8441 workaround
petermao Mar 14, 2023
228a3c8
Merge dev: update author/maintainer lists
petermao Mar 15, 2023
582e2bf
Add MELPA badge to README.org (#1)
Samoed Mar 21, 2023
e54e71b
Update README to include straight.el instructions (#4)
chatziiola Mar 24, 2023
8b99e50
clean up installation notes in README and make CUSTOMIZATIONS.org
petermao Mar 24, 2023
e04e8fd
+HOWTO (multicolumn), move CUSTOMIZATIONS into docs/
petermao Mar 25, 2023
4daf946
temporary support for issue #6
petermao Mar 26, 2023
9a1722c
Merge dev: documentation (README, CUSTOMIZATIONS, HOWTO)
petermao Mar 27, 2023
aaf3421
Nov.el has been moved
Mar 28, 2023
fb6573a
Merge pull request #10 from brandelune/patch-1
petermao Mar 28, 2023
02eebc0
autoload org-noter-start-from-dired from org-noter.el
petermao Mar 30, 2023
8701093
Merge pull request #11 from org-noter/bugfix/start-from-dired
dmitrym0 Mar 30, 2023
ac50ea2
[ISSUE-9] Try to load packages before emitting a warning that a packa…
dmitrym0 Apr 3, 2023
5715ddf
conform to emacs standard for error messages
petermao Apr 4, 2023
a24ba82
Merge pull request #13 from org-noter/bugfix/issue-9
petermao Apr 4, 2023
7b9e450
bugfix: issue #12 (open document to saved location)
petermao Apr 5, 2023
b195705
Initial refactoring to support notes in arbitrary files.
dmitrym0 Apr 11, 2023
edb25be
+1 to previous commit; forgot to actually stage the bulk of the
dmitrym0 Apr 11, 2023
0e0e927
Add org-noter--find-top-level-heading-for-publication-path and associ…
dmitrym0 Apr 11, 2023
dec21ad
Add test coverage to `make test`.
dmitrym0 Apr 12, 2023
91c6c97
Add a descriptive comment to the function.
dmitrym0 Apr 12, 2023
52c808e
When opening from a publication, allow an org-roam notes file to be s…
dmitrym0 Apr 12, 2023
bf369ab
Keep forgetting to commit correct files.
dmitrym0 Apr 12, 2023
df7bc73
Force emacs 28.2
dmitrym0 Apr 12, 2023
e5d5a5e
Temporarily comment out tests that rely on a local file system.
dmitrym0 Apr 12, 2023
f929b00
Dump emacs version when running tests.
dmitrym0 Apr 12, 2023
c234cd8
Disable 1 test.
dmitrym0 Apr 12, 2023
c36394e
Disable 1 test.
dmitrym0 Apr 12, 2023
9118c7e
Reenable tests.
dmitrym0 Apr 12, 2023
cd616f2
re-enable broken test, with a twist.
dmitrym0 Apr 12, 2023
7619b8f
Add an assert to make sure heading is always non-nil
dmitrym0 Apr 12, 2023
586584b
Modify invocation to see if we can figure out what is going on.
dmitrym0 Apr 12, 2023
00af868
Lets print the buffer. what is going on.
dmitrym0 Apr 12, 2023
3880546
make sure we create a temp file.
dmitrym0 Apr 12, 2023
3856c1b
Merge pull request #14 from org-noter/bugfix/issue-12
petermao Apr 21, 2023
54318b4
standardize pdf module function names
petermao Apr 24, 2023
ff424d4
standardive nov module function names
petermao Apr 24, 2023
1ab9237
standardive djvu module function names
petermao Apr 24, 2023
46e639a
move (pdf specific) org-noter--show-arrow into pdf module
petermao Apr 30, 2023
7bd1145
move declare-function on pdf-* to modules/-pdf.el - buggy
petermao Apr 30, 2023
be25512
explicitly call (require 'pdf-tools) - works
petermao Apr 30, 2023
1aaea12
expunge declare-function's from modules/-pdf.el - works
petermao Apr 30, 2023
28a868b
(require 'pdf-annot) was not being called anyways
petermao Apr 30, 2023
c18c285
fix flycheck warning (minor)
petermao Apr 30, 2023
d541042
condition-case...require <optional-packages> at compile time
petermao Apr 30, 2023
eb18b87
document type (pdf, nov) advice isolation
petermao Apr 30, 2023
62373cd
clean up some NOV flycheck warnings
petermao Apr 30, 2023
5590b4b
remove improper use of --with-valid-session in nov module
petermao May 2, 2023
d1a8b01
Merge pull request #22 from org-noter/maintenance/pdf-modularization
petermao May 5, 2023
6546c2e
bugfix: typo in modules/nov advice removal
petermao May 5, 2023
3d13ab7
Merge pull request #25 from org-noter/bugfix/nov-mode
petermao May 10, 2023
ff33ab6
toggle notes-window-location
petermao May 7, 2023
f73cf2c
refactor notes-window locating code
petermao May 12, 2023
cd93b9e
update README
petermao May 15, 2023
6375210
Add issue template and PR template.
dmitrym0 May 20, 2023
49315b5
Merge pull request #31 from org-noter/feature/add-issue-and-pr-templates
dmitrym0 May 21, 2023
948f9c3
Restore "standard" org-noter functionality but enable Notes file open…
dmitrym0 May 21, 2023
e11e4ad
Revert tests.
dmitrym0 May 21, 2023
c7fcc82
Revert cask.
dmitrym0 May 21, 2023
fb6b1ba
Revert test utils.
dmitrym0 May 21, 2023
1129470
Reverting test files.
dmitrym0 May 21, 2023
191455f
Remove debugging output.
dmitrym0 May 21, 2023
28b6778
Add test coverage to builds.
dmitrym0 May 21, 2023
cd4f2ef
Do not include org-noter from sub-tests.
dmitrym0 May 21, 2023
5fb8daf
Add a code coverage badge to readme.
dmitrym0 May 21, 2023
90825f5
Update org link to coverage.
dmitrym0 May 21, 2023
0938146
Merge pull request #27 from org-noter/feature/toggle-notes-window-loc…
petermao May 21, 2023
aa6d3d2
Merge pull request #33 from org-noter/feature/add-test-coverage
dmitrym0 May 23, 2023
38df833
Replace `publication` with `document` to be more consistent.
dmitrym0 May 28, 2023
0370777
Add periods to the end of the docstring.
dmitrym0 May 28, 2023
9863a48
bugfix: typo in hook name
petermao May 30, 2023
a38730c
flycheck suggested documenetation changes.
petermao May 30, 2023
8a9b7c3
bugfix - argument file was not used
petermao May 30, 2023
c913a15
Add tests for the open-from-document hook.
dmitrym0 May 31, 2023
d267c25
Fix the hook name.
dmitrym0 May 31, 2023
a274340
Insist that bug reporters start emacs with "-Q"
petermao Jun 1, 2023
1fbf598
Merge pull request #32 from org-noter/feature/generalize-file-opening…
dmitrym0 Jun 5, 2023
89d819a
override `C-c C-c` and `C-c C-x C-v` in pdf-view-mode
petermao Jun 11, 2023
73c7f5e
Make C-c C-x ?? doc -> notes trick work for all 3-key sequences
petermao Jun 11, 2023
3d155a0
guarantee focus switch to notes window
petermao Jun 11, 2023
7b015ba
wip: tests for pdf keybinding override feature
petermao Jun 11, 2023
652521d
replace lambda in `define-key' calls with named functions
petermao Jun 13, 2023
e7af76c
use the less restrictive `string-equal` vs `file-equal-p`
petermao Jun 24, 2023
7163b0a
prototype code for syncing notes files when docs are renamed
petermao Jun 24, 2023
e862b45
clean up finding for candidate notes files
petermao Jun 24, 2023
97185b1
advise dired-rename-file -- works!
petermao Jun 24, 2023
b1ece56
check for successful rename in --sync-doc-rename-in-notes
petermao Jun 25, 2023
8df9905
move code from phmdev.el into org-noter
petermao Jun 25, 2023
0541dd9
org-noter--sync-notes-rename-in-notes and enable/disable functions
petermao Jun 27, 2023
f2d5188
Add documentation of sync-rename functions.
petermao Jun 27, 2023
f9710c9
Merge pull request #42 from org-noter/feature/override-pdfview-keybin…
petermao Jun 28, 2023
ec76c7a
add optional decoration to headline title
petermao Jul 1, 2023
980a124
bugfix - skip filenames w/o extensions
petermao Jul 9, 2023
e84c622
for cask, use melpa rather than melpa-stable
petermao Jul 11, 2023
9f7f383
Merge pull request #47 from org-noter/feature/headline-title-decoration
petermao Jul 28, 2023
6ca079c
change the verb of this feature from "sync" to "update"
petermao Jul 28, 2023
4d47516
Merge pull request #44 from org-noter/feature/sync-noter-document
petermao Jul 28, 2023
be4f56e
wip: update function names ("-pdftools-"), documentation
petermao Aug 3, 2023
0057c9a
wip: update function names to modern usage
petermao Aug 3, 2023
d8d6ec2
wip: use link prefix `org-pdftools-link-prefix' instead of "pdftools:"
petermao Aug 3, 2023
79d8e1c
wip: use `...-pdftools-path-generator'
petermao Aug 3, 2023
6e06237
wip: add `...-insert-*-heading' defcustoms (default t)
petermao Aug 3, 2023
bae9235
wip: corresponds to 3 commits from org-noter-pdftools
petermao Aug 3, 2023
8f52678
wip: strip trailing ]] from location-property for processing
petermao Aug 3, 2023
d42a280
wip: last big diff to incorporate "Save your org notes to PDF"
petermao Aug 3, 2023
289e82f
wip: require packages org-id and image-mode
petermao Aug 3, 2023
a98f7ae
restore Xi Fu's authorship header to ...-integration
petermao Aug 3, 2023
09fe1df
Merge pull request #52 from org-noter/pdftools-integration
petermao Aug 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
condition-case...require <optional-packages> at compile time
Resolution to PR #22.

`org-noter-pdf--show-arrow` seems particularly sensitive to this issue.  Now for
each module there is a `condition-case ... require` both at compile time and run
time.  Ugly, but it seems to work.
petermao committed Apr 30, 2023
commit d541042157c312d3ddf313b18ae35cad7c19b939
7 changes: 5 additions & 2 deletions modules/org-noter-djvu.el
Original file line number Diff line number Diff line change
@@ -25,8 +25,11 @@
;;; Code:
(require 'org-noter-core)


(condition-case nil
(eval-when-compile ; ensure that the compiled code knows about DJVU, if installed
(condition-case nil
(require 'djvu)
(error (message "`djvu' package not found"))))
(condition-case nil ; run time warning
(require 'djvu)
(error (message "ATTENTION: org-noter-djvu needs the package `djvu'")))

6 changes: 5 additions & 1 deletion modules/org-noter-nov.el
Original file line number Diff line number Diff line change
@@ -25,7 +25,11 @@
;;; Code:
(require 'org-noter-core)

(condition-case nil
(eval-when-compile ; ensure that the compiled code knows about NOV, if installed
(condition-case nil
(require 'nov)
(error (message "`nov' package not found"))))
(condition-case nil ; run time warning
(require 'nov)
(error (message "ATTENTION: org-noter-nov needs the package `nov'")))

6 changes: 5 additions & 1 deletion modules/org-noter-pdf.el
Original file line number Diff line number Diff line change
@@ -26,7 +26,11 @@
(eval-when-compile (require 'subr-x))
(require 'cl-lib)
(require 'org-noter-core)
(condition-case nil
(eval-when-compile ; ensure that the compiled code knows about PDF-TOOLS, if installed
(condition-case nil
(require 'pdf-tools)
(error (message "`pdf-tools' package not found"))))
(condition-case nil ; inform user at run time if pdf-tools is missing
(require 'pdf-tools)
(error (message "ATTENTION: org-noter-pdf has many featues that depend on the package `pdf-tools'")))