Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better error handling when bigquery returns table not exists #256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+30 −8
Open

fix: Better error handling when bigquery returns table not exists #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2521468
fix: Better error handling and avoid wait if no error is recived
giomerlin Feb 29, 2020
e8d5d1c
fix: Better error handling when bigquery returns table not exists
giomerlin Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/BigQuerySinkTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ private SchemaManager getSchemaManager(BigQuery bigQuery) {
if (testSchemaManager != null) {
return testSchemaManager;
}
schemaRetriever = config.getSchemaRetriever();

if ( schemaRetriever == null) {
schemaRetriever = config.getSchemaRetriever();
}

SchemaConverter<com.google.cloud.bigquery.Schema> schemaConverter =
config.getSchemaConverter();
Optional<String> kafkaKeyFieldName = config.getKafkaKeyFieldName();
Expand Down
32 changes: 25 additions & 7 deletions ...ctor/src/main/java/com/wepay/kafka/connect/bigquery/write/row/AdaptiveBigQueryWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,20 @@ && onlyContainsInvalidSchemaErrors(writeResponse.getInsertErrors()) && autoUpdat
}
} catch (BigQueryException exception) {
// Should only perform one table creation attempt.
if (isTableNotExistedException(exception) && autoCreateTables && bigQuery.getTable(tableId.getBaseTableId()) == null) {
attemptTableCreate(tableId.getBaseTableId(), topic);
if (isTableNotExistedException(exception) && autoCreateTables ) {
//In some cases the table exists but the partition still is not created,
// so we should no throw an exception but wait
try {
if (bigQuery.getTable(tableId.getBaseTableId()) == null) {
attemptTableCreate(tableId.getBaseTableId(), topic);
}
} catch(BigQueryConnectException ex) {
BigQueryException cause = (BigQueryException)ex.getCause();
//Ignore the exception because the table already exists
if ( !(cause.getCode() == 409 && cause.getReason().equalsIgnoreCase("duplicate"))) {
throw ex;
}
}
} else if (isTableMissingSchema(exception) && autoUpdateSchemas) {
attemptSchemaUpdate(tableId, topic);
} else {
Expand All @@ -129,7 +141,11 @@ && onlyContainsInvalidSchemaErrors(writeResponse.getInsertErrors()) && autoUpdat
logger.debug("re-attempting insertion");
writeResponse = bigQuery.insertAll(request);
} catch (BigQueryException exception) {
// no-op, we want to keep retrying the insert
// When autoCreateTable is used with autoUpdateSchemas and the MemorySchemaRetriever
// a table with no schema can appear and is necessary to check again
if (isTableMissingSchema(exception) && autoUpdateSchemas) {
attemptSchemaUpdate(tableId, topic);
}
}
} else {
return writeResponse.getInsertErrors();
Expand All @@ -140,10 +156,12 @@ && onlyContainsInvalidSchemaErrors(writeResponse.getInsertErrors()) && autoUpdat
"Failed to write rows after BQ schema update within "
+ RETRY_LIMIT + " attempts for: " + tableId.getBaseTableId());
}
try {
Thread.sleep(RETRY_WAIT_TIME);
} catch (InterruptedException e) {
// no-op, we want to keep retrying the insert
if (writeResponse == null || writeResponse.hasErrors()) {
try {
Thread.sleep(RETRY_WAIT_TIME);
} catch (InterruptedException e) {
// no-op, we want to keep retrying the insert
}
}
}
logger.debug("table insertion completed successfully");
Expand Down