-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New thematic for starting or expanding a family. #2465
base: master
Are you sure you want to change the base?
Conversation
@BrahimMahadi can you review and test? Each thematic and experimentation must be independent from each other. This impact the following existing project, and some additional change might be required according to their implementation plan.
|
Note: It can't be "th-journeylab" because that don't represent a thematic but represent a product specific. |
Noted. That being said, it would be a bit of a moot point if you would like the thematics to be completely separate. This folder contains the SCSS called by Empathy and "Vitality". It's not really a thematic by itself per say. |
- Fixes to the steps quiz plugin. Labels were bigger than container so text would go on top of borders in small viewports - Remove Empathy thematic changes from this PR.
I'm hoping it compiles just fine and doesn't have linting issues. Thanks @BrahimMahadi! |
@fsnoddy I've done a quick test and the page now loads in the test environment, however the css for the colours does not seem to work. I think the problem has to do with the use of the mixins in the saas file. cc: @duboisp @Garneauma ![]() |
@fsnoddy Please split this PR into 2 PRs; one for the Steps quiz and one for the Thematic. Thanks! |
@BrahimMahadi @Garneauma, I removed the steps quiz changes from the PR. I'll submit these in a new one. |
Pre-approved upon successful review. |
@fsnoddy FYI the label width override from one of your earlier commits probably won't be necessary in your new PR since it's already covered by #2436. Not sure why it's still open to this day though :S. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsnoddy Missing a few working examples for the new styles added. Also, please update style.css so that there is not a new empty line after every line of code. Thanks!
… background classes.
…ckground and checklist classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsnoddy Only one small change left. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment with the following:
- Clear and simple explanations of the new feature, change or update;
- The impact on the sponsored department of the new feature, change or update;
- The impact on the public of the new feature, change or update.
Some small changes to the meta.md file (you can just commit the suggestions as is). Thank you!
cssClass: | ||
- vitality | ||
- btn-vitality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some missing classes
cssClass: | |
- vitality | |
- btn-vitality | |
cssClass: | |
- vitality | |
- btn-vitality | |
- text-vitality | |
- bg-vitality |
- title: Vitality theme | ||
language: en | ||
path: vitality.html | ||
sponsor: ESDC - Portfolio web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a contact person.
sponsor: ESDC - Portfolio web | |
sponsor: Francis Snoddy on behalf of ESDC - Portfolio web |
I've reworked the current Loss of a Loved one CSS to use Sass.
New themes for journey labs now need 4-5 lines just setting theme name, primary and secondary color. Hoping this can reduce the workload and maintenance on both of our sides.