Editorial: Create the build a content range algorithm #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Aug 24, 2023
fetch.bs
Outdated
|
|
||
| <li><p>Append <var>serializedFullLength</var> to <var>contentRange</var>. | ||
| <li><p>Let <var>contentRange</var> be the result of invoking <a>build a content range</a> | ||
| given <var>rangeStart</var>, <var>rangeEnd</var>, and <var>slicedBlob</var>'s {{Blob/size}}. |
There was a problem hiding this comment.
You go from serializedFullLength to serializedSlicedLength here. That seems wrong.
There was a problem hiding this comment.
Ah! You are correct!
Move the content-range algorithm to a standalone algorithm to avoid the additional inlined steps in Scheme fetch.
dlrobertson
force-pushed
the
content-range
branch
from
6fbb9e9
to
96c4d27
Compare
annevk
approved these changes
Aug 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the content-range algorithm to a standalone algorithm to avoid the additional inlined steps in Scheme fetch.
Fixes: #1552
Preview | Diff