Replace request's "window" with "traversable for user prompts" #1823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After much discussion in #1820 and #1821, this seems to be more correct. Closes #1820. Closes #1821. Helps whatwg/html#11250 specify browser-initiated navigations better.
domenic
added
the
do not merge yet
annevk
approved these changes
May 9, 2025
| <a for="environment settings object">global object</a> is a | ||
| {{Window}} object). Unless stated otherwise it is | ||
| "<code>client</code>". | ||
| <dfn export for=request id=concept-request-window>traversable for user prompts</dfn>, that is |
There was a problem hiding this comment.
I'm trying to write out "end user" where I can myself. I'm not actually sure where we are consistency-wise, but is that something we can strife for? I'm happy to document it as the term to use.
| agent should avoid displaying content from the request's initiator in the | ||
| <a for=request>traversable for user prompts</a>, especially in the case of cross-origin requests. | ||
| Displaying a blank page behind such prompts is a good way to fulfill these requirements. Failing to | ||
| follow these guidelines can confuse users as to which origin is responsible for the prompt. |
There was a problem hiding this comment.
Suggested change
| follow these guidelines can confuse users as to which origin is responsible for the prompt. | |
| follow these guidelines can confuse end users as to which origin is responsible for the prompt. |
| "<code>no-traversable</code>". | ||
|
|
||
| <li> | ||
| <p>If <var>request</var>'s <a for=request>client</a> is non-null, then: |
There was a problem hiding this comment.
Suggested change
| <p>If <var>request</var>'s <a for=request>client</a> is non-null, then: | |
| <p>If <var>request</var>'s <a for=request>client</a> is non-null: |
| <li><p>Let <var>global</var> be <var>request</var>'s <a for=request>client</a>'s | ||
| <a for="environment settings object">global object</a>. | ||
|
|
||
| <li><p>If <var>global</var> is a {{Window}} object, and <var>global</var>'s |
There was a problem hiding this comment.
Suggested change
| <li><p>If <var>global</var> is a {{Window}} object, and <var>global</var>'s | |
| <li><p>If <var>global</var> is a {{Window}} object and <var>global</var>'s |
| <var>httpFetchParams</var> to <var>fetchParams</var> and <var>httpRequest</var> to | ||
| <var>request</var>. | ||
| <li> | ||
| <p>If <var>request</var>'s <a for=request>traversable for user prompts</a> is "<code>no-traversable</code>" and |
| <var>httpFetchParams</var> to <var>fetchParams</var> and <var>httpRequest</var> to | ||
| <var>request</var>. | ||
|
|
||
| <p class=note>If user prompts are possible, then we need to clone <var>request</var> because ??? |
There was a problem hiding this comment.
Because it's one of the scenarios where we might have to repeat request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much discussion in #1820 and #1821, this seems to be more correct. Closes #1820. Closes #1821. Helps whatwg/html#11250 specify browser-initiated navigations better.
(See WHATWG Working Mode: Changes for more details.)
Marking as "do not merge yet" as we should prepare PRs for all of https://dontcallmedom.github.io/webdex/w.html#window%40%40request%40dfn . But I don't want to do that until we've confirmed this is the right path, since it's my third attempt 😅
Preview | Diff