Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editorial] Fix missing references to OffscreenCanvas as CanvasImageSource #10027

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Kaiido
Copy link
Member

@Kaiido Kaiido commented Dec 28, 2023

A few places that do expect a CanvasImageSource omit the OffscreenCanvas interface case, while it is defined as being one in https://html.spec.whatwg.org/multipage/canvas.html#canvasimagesource.
A couple of non-normative notes also were missing notes about OffscreenCanvas.

Since the WebIDL is already enforcing that OffscreenCanvas is part of CanvasImageSource, this is merely an editorial change.

  • At least two implementers are interested (and none opposed):
    • N/A, this is a non-normative change.
  • Tests are written and can be reviewed and commented upon at:
    • N/A
  • Implementation bugs are filed:
    • N/A
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/canvas.html ( diff )

A few places that do expect a CanvasImageSource omit the OffscreenCanvas interface, while it is defined as being one in https://html.spec.whatwg.org/multipage/canvas.html#canvasimagesource
A couple of non-normative notes also were missing notes about OffscreenCanvas.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these missing definitions feel a bit more substantial, so I'll call this a non-editorial bugfix.

@domenic domenic merged commit 67b4e22 into whatwg:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants