Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow render-blocking inline module scripts #10035

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Allow render-blocking inline module scripts #10035

merged 3 commits into from
Jan 18, 2024

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jan 3, 2024 •
edited by pr-preview bot
Loading

There is no reason to limit render-blocking to scripts with src only. A module/async/defer script with imports should behave just the same.

Closes #10034

(See WHATWG Working Mode: Changes for more details.)

/scripting.html ( diff )

@noamr noamr mentioned this pull request Jan 8, 2024
Closed
@zcorpan zcorpan mentioned this pull request Jan 9, 2024
Closed
@noamr noamr changed the title Allow render-blocking inline scripts Allow render-blocking inline module scripts Jan 10, 2024
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 10, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
bd49de7 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jan 10, 2024
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 10, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
ea3c7ab 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 10, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
72be027 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 10, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
f1f398f 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 15, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
c4a6893 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
domenic
domenic reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a nit.

There's a preexisting issue with a lack of document conformance requirements for blocking + script, but we can solve that separately. (I'll file a new issue for it.)

@domenic domenic merged commit 77bba4f into whatwg:main Jan 18, 2024
2 checks passed
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 23, 2024
@noamr
Enable render-blocking inline module scripts
5d1fb3a 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 23, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
6e77993 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 23, 2024
@noamr @chromium-wpt-export-bot
Enable render-blocking inline module scripts
9bb6e1d 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 29, 2024
@noamr @moz-wptsync-bot
Bug 1873891 [wpt PR 43919] - Enable render-blocking inline module scr…
dca03a7 
…ipts, a=testonly

Automatic update from web-platform-tests
Enable render-blocking inline module scripts

Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}

--

wpt-commits: 9bb6e1dbfbadf85634936171144d8a9f17fc9f56
wpt-pr: 43919
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Jan 30, 2024
@noamr @moz-wptsync-bot
Bug 1873891 [wpt PR 43919] - Enable render-blocking inline module scr…
0c927d7 
…ipts, a=testonly

Automatic update from web-platform-tests
Enable render-blocking inline module scripts

Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}

--

wpt-commits: 9bb6e1dbfbadf85634936171144d8a9f17fc9f56
wpt-pr: 43919
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Feb 1, 2024
@marco-c
Bug 1873891 [wpt PR 43919] - Enable render-blocking inline module scr…
1c1dc00 
…ipts, a=testonly

Automatic update from web-platform-tests
Enable render-blocking inline module scripts

Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalchromium.org>
Cr-Commit-Position: refs/heads/main{#1250749}

--

wpt-commits: 9bb6e1dbfbadf85634936171144d8a9f17fc9f56
wpt-pr: 43919

UltraBlame original commit: 17b42b2c3ac25e55c8c2d49f60701b30c17773e0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Feb 1, 2024
@marco-c
Bug 1873891 [wpt PR 43919] - Enable render-blocking inline module scr…
3311036 
…ipts, a=testonly

Automatic update from web-platform-tests
Enable render-blocking inline module scripts

Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalchromium.org>
Cr-Commit-Position: refs/heads/main{#1250749}

--

wpt-commits: 9bb6e1dbfbadf85634936171144d8a9f17fc9f56
wpt-pr: 43919

UltraBlame original commit: 17b42b2c3ac25e55c8c2d49f60701b30c17773e0
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
@noamr @marcoscaceres
Enable render-blocking inline module scripts
630f216 
Inline module scripts need to behave like scripts with `src` in many
ways, e.g. if they have imports. Otherwise authors have to use a
fake `src` for artificial reasons.

This implements the spec PR:
whatwg/html#10035

Currently behind a flag (RenderBlockingInlineModuleScript)

Bug: 1514881
Change-Id: I8579d721adbf976a1d5e20d14abc6ef7252b0718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5184455
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1250749}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render-blocking scripts should also work for inline scripts
2 participants
@noamr @domenic