[Editorial] rework button states to allow for command/commandfor attributes #10960
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
keithamus
force-pushed
the
rework-button-states-to-allow-for-command-commandfor-attributes
branch
from
5dea222 to
211e3b8
Compare
|
Hey @foolip I've addressed your feedback, would be great to get another review pass if you have time? |
Reset doesnt return! Keeping this editorial only is important
Two questions: is this behavior change intentional? (Side-question, if yes: why?) And most importantly, if the intention is to try to land this behavior change, has someone done the compat analysis? I'd be a bit concerned. When we landed popover initially, the desired behavior was that the popover gets triggered unless the button would otherwise take a form action. That's roughly category 1. We didn't restrict category 2. |
|
Apologies I should have updated my comment it's no longer applicable. Keith has fixed the changes. I should note that the spec does currently differ from chromium but that's a separate discussion to be had imo. |
|
Thanks @keithamus! I hope rebasing on top of this won't be too much of a hassle 😅 |
keithamus
deleted the
rework-button-states-to-allow-for-command-commandfor-attributes
branch
| @@ -45861,8 +45861,8 @@ interface <dfn interface>HTMLTableCellElement</dfn> : <span>HTMLElement</span> { | |||
|
|
|||
| <p>Some <span data-x="category-submit">submittable elements</span> can be, depending on their | |||
| attributes, <dfn data-x="concept-button">buttons</dfn>. The prose below defines when an element | |||
| is a button. Some buttons are specifically <dfn export data-lt="submit button" | |||
| data-x="concept-submit-button">submit buttons</dfn>.</p> | |||
There was a problem hiding this comment.
I don't see how you can move this definition to the button element section. The button element is not alone in being able to be a submit button.
There was a problem hiding this comment.
My bad, this swap of definition and use was my suggestion in #10960 (comment). I didn't check other uses of the concept and now see that it's used a lot to make various things "specifically a submit button."
This PR changes the way button elements represent their state; specifically how they are defined as submit buttons. This also re-writes some of the generic algorithms (such as the IDL reflection) to be manual steps.
The intent of this change is to carve out the space for the new
commandandcommandforattributes. Most of these changes are already in #9841 but this PR separates them out to shrink the amount of changes inside #9841./form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/forms.html ( diff )
/input.html ( diff )
/nav-history-apis.html ( diff )
/popover.html ( diff )
/semantics-other.html ( diff )