Add request-close command for dialogs #11045
Conversation
This new command maps to the dialog's requestClose function.
| <li><p><span data-x="close-watcher-request-close">Request to close</span> <var>subject</var>'s | ||
| <span data-x="dialog-close-watcher">close watcher</span> with false.</p></li> | ||
|
|
||
| <li><p>Set <var>subject</var>'s <span>enable close watcher for <code |
There was a problem hiding this comment.
I think we want to check here if the dialog is still open; and avoid running the next step, otherwise users may close the dialog on cancel.
There was a problem hiding this comment.
Based on our discussion earlier I think we're in agreement this isn't needed. The various close watcher mechanics already guard against these various states. And improvements to open attribute handling will improve the situation wholesale.
There was a problem hiding this comment.
Yes, the edge cases aren't exclusive to this case and there needs to be more holistic work for dialogs here.
domenic
added
addition/proposal
| data-x="attr-button-command-show-modal-state">Show Modal</span> state, then | ||
| return true.</p></li> | ||
| data-x="attr-button-command-close-state">Close</span> state, <span | ||
| data-x="attr-button-command-request-close-state">Request Close</span> state or the <span |
There was a problem hiding this comment.
| data-x="attr-button-command-request-close-state">Request Close</span> state or the <span | |
| data-x="attr-button-command-request-close-state">Request Close</span> state, or the <span |
| @@ -62501,6 +62491,20 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> { | |||
| </ol> | |||
| </li> | |||
|
|
|||
| <li> | |||
| <p>If <var>command</var> is in the <span | |||
| data-x="attr-button-command-request-close-state">Close</span> state and <var>element</var> has | |||
There was a problem hiding this comment.
| data-x="attr-button-command-request-close-state">Close</span> state and <var>element</var> has | |
| data-x="attr-button-command-request-close-state">Request Close</span> state and <var>element</var> has |
| watcher</span> is not null.</p></li> | ||
|
|
||
| <li><p>Set <var>subject</var>'s <span>enable close watcher for <code | ||
| data-x="dom-dialog-requestClose">requestClose()</code></span> to true.</p></li> |
There was a problem hiding this comment.
I guess we should rename this from "enable close watcher for requestClose()" to "enable close watcher for request close".
(Also, adding a <p class="note"> explanation on the purpose of that field would be helpful, as I forgot why it exists... maybe it forces request-close behavior even if we would otherwise skip it? I can't quite remember.)
There was a problem hiding this comment.
It's because closedby=none dialogs have their close watcher disabled by default so this temporarily enables it for request close to work. Good point about a note.
Add request-close command for dialogs
This new command maps to the dialog's requestClose function.
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/indices.html ( diff )
/interactive-elements.html ( diff )