Correct button activation behavior to block auto state buttons from being command buttons #11048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing command buttons
|
cc @keithamus I want to clarify whether the buttons type attribute really should be invalid AUTO not invalid submit? I guess given we allow type="reset" it might make sense to allow type="foobar" to work as a submit button but imo it's less obvious. |
|
Based on discussions in whatnot I'm going to put up a new PR that supersedes this |
|
I guess this is replaced by #11053? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct button activation behavior to block auto state buttons from being command buttons
Fixes #11044
See #10832 for more context
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )