Success lint

wilkerlucio · Apr 18, 2021 · 045f536 · 045f536
1 parent 37dc32b
commit 045f536
Show file tree

Hide file tree

Showing 33 changed files with 208 additions and 277 deletions.
diff --git a/.clj-kondo/config.edn b/.clj-kondo/config.edn
@@ -1,21 +1,23 @@
 {:config-paths ["com.wsscode/async"
                 "com.wsscode/pathom"
                 "com.wsscode/pathom3"]
- :lint-as      {clojure.test.check.clojure-test/defspec  clojure.core/def
-                clojure.test.check.properties/for-all    clojure.core/let
-                nubank.workspaces.core/defcard           clojure.core/def
-                nubank.workspaces.core/deftest           clojure.core/def
-                com.fulcrologic.fulcro.components/defsc  clojure.core/defn
-                com.fulcrologic.guardrails.core/>def     clojure.spec.alpha/def
-                com.fulcrologic.guardrails.core/>defn    clojure.core/defn
-                com.wsscode.pathom.viz.embed.macros/defc clojure.core/defn
-                com.wsscode.promesa.macros/clet          clojure.core/let
-                helix.core/defnc                         clojure.core/defn
-                potemkin.collections/def-map-type        clojure.core/deftype
-                promesa.core/let                         clojure.core/let
-                promesa.core/loop                        clojure.core/loop}
+ :lint-as      {clojure.test.check.clojure-test/defspec      clojure.core/def
+                clojure.test.check.properties/for-all        clojure.core/let
+                com.fulcrologic.fulcro.components/defsc      clojure.core/defn
+                com.fulcrologic.fulcro.mutations/defmutation clj-kondo.lint-as/def-catch-all
+                com.fulcrologic.guardrails.core/>def         clojure.spec.alpha/def
+                com.fulcrologic.guardrails.core/>defn        clojure.core/defn
+                com.wsscode.pathom.viz.embed.macros/defc     clojure.core/defn
+                com.wsscode.promesa.macros/clet              clojure.core/let
+                helix.core/defnc                             clojure.core/defn
+                nubank.workspaces.core/defcard               clojure.core/def
+                nubank.workspaces.core/deftest               clojure.core/def
+                potemkin.collections/def-map-type            clojure.core/deftype
+                promesa.core/let                             clojure.core/let
+                promesa.core/loop                            clojure.core/loop}
  :linters      {:invalid-arity       {:level :error}
                 :missing-else-branch {:level :off}
+                :private-call        {:level :off}
                 :unresolved-symbol   {:exclude [match? thrown-match?]}
                 :consistent-alias    {:level   :warning
                                       :aliases {com.wsscode.async.processing  wap

diff --git a/src/cards/com/wsscode/pathom/viz/index_explorer_cards.cljs b/src/cards/com/wsscode/pathom/viz/index_explorer_cards.cljs
@@ -106,7 +106,7 @@
                                                   {::iex/plugins [abrams-plugin]}}}))
 
 (fc/defsc AttributeGraphDemo
-  [this {::keys []}]
+  [_this {::keys []}]
   {:pre-merge     (fn [{:keys [current-normalized data-tree]}]
                     (merge {:ui/id (random-uuid)} current-normalized data-tree))
    :initial-state {}

diff --git a/src/cards/com/wsscode/pathom/viz/query_plan_cards.cljs b/src/cards/com/wsscode/pathom/viz/query_plan_cards.cljs
@@ -146,8 +146,7 @@
     children))
 
 (fc/defsc QueryPlanWrapper
-  [this {::keys   [examples]
-         :ui/keys [plan query node-details label-kind trace-tree]}]
+  [this {:ui/keys [plan query node-details label-kind trace-tree]}]
   {:pre-merge   (fn [{:keys [current-normalized data-tree]}]
                   (merge {::id           (random-uuid)
                           :ui/plan       nil
@@ -179,23 +178,12 @@
                       (let [query      (-> this fc/props :ui/query safe-read)
                             t*         (atom [])
                             res        (<?maybe (parser {:com.wsscode.pathom.trace/trace* t*} query))
-                            trace      (pt/compute-durations @t*)
-                            plans      (->> trace
-                                            (filter (comp #{::pc/compute-plan} ::pt/event))
-                                            (filter (comp seq ::pcp/nodes ::pc/plan)))
                             trace-tree (pt/trace->viz @t*)]
                         (js/console.log "RES" res)
                         (fm/set-value! this :ui/plan nil)
                         (fm/set-value! this :ui/node-details nil)
                         (fm/set-value! this :ui/trace-tree trace-tree))))]
     (dom/div :.container
-      #_(dom/div
-          (dom/select {:value    plan
-                       :onChange #(fm/set-string! this :ui/plan :event %)}
-            (dom/option "Select example")
-            (for [[title _] examples]
-              (dom/option {:key title} title))))
-
       (dom/div :.editor
         (cm/pathom
           {:value       (or (str query) "")
@@ -239,7 +227,7 @@
                label-kind
 
                ::plan-view/on-click-node
-               (fn [e node]
+               (fn [_ node]
                  (js/console.log "NODE" node)
                  (fm/set-value! this :ui/node-details
                    (if (= node-details node)

diff --git a/src/cards/com/wsscode/pathom/viz/react_hooks_cards.cljs b/src/cards/com/wsscode/pathom/viz/react_hooks_cards.cljs
@@ -1,8 +1,6 @@
 (ns com.wsscode.pathom.viz.react-hooks-cards
   (:require [nubank.workspaces.card-types.fulcro3 :as ct.fulcro]
-            [nubank.workspaces.card-types.react :as ct.react]
             [nubank.workspaces.core :as ws]
-            [nubank.workspaces.model :as wsm]
             [com.fulcrologic.fulcro-css.localized-dom :as dom]
             [com.fulcrologic.fulcro.components :as fc]
             [com.wsscode.pathom.viz.helpers :as h]))
@@ -73,23 +71,23 @@
 (def SampleContext (h/create-context (:light themes)))
 
 (fc/defsc ContextDemoThemedButton
-  [this props]
+  [this _props]
   {:use-hooks? true}
   (let [theme (h/use-context SampleContext)]
     (dom/button {:style theme} (fc/children this))))
 
 (def context-demo-themed-button (fc/factory ContextDemoThemedButton))
 
 (fc/defsc ContextDemoToolbar
-  [this {::keys []}]
+  [_this {::keys []}]
   {:use-hooks? true}
   (dom/div
     (context-demo-themed-button {} "Button Content")))
 
 (def context-demo-toolbar (fc/factory ContextDemoToolbar))
 
 (fc/defsc ContextDemoApp
-  [this {::keys []}]
+  [_this {::keys []}]
   {:use-hooks? true}
   (h/create-context-provider SampleContext {:value (:dark themes)}
     (context-demo-toolbar {})))
@@ -101,7 +99,7 @@
     (fn []
       (context-demo-app {}))))
 
-(defn sample-reducer [state {:keys [type] :as action}]
+(defn sample-reducer [state {:keys [type]}]
   (case type
     ::increment
     (update state :count inc)
@@ -150,11 +148,11 @@
 (ws/defcard use-layout-effect-card
   (hook-demo-card
     (fn []
-      (let [ref (h/use-layout-effect (fn []
-                                       (js/console.log ">>>> Layout Effect")
-                                       (fn []
-                                         (js/console.log "<<<< Layout Effect")))
-                  [])]
+      (let [_ref (h/use-layout-effect (fn []
+                                        (js/console.log ">>>> Layout Effect")
+                                        (fn []
+                                          (js/console.log "<<<< Layout Effect")))
+                   [])]
         (dom/div "Check console")))))
 
 (ws/defcard use-debug-value-card

diff --git a/src/cards/com/wsscode/pathom/viz/request_history_cards.cljs b/src/cards/com/wsscode/pathom/viz/request_history_cards.cljs
@@ -2,7 +2,6 @@
   (:require [com.fulcrologic.guardrails.core :refer [>def >defn >fdef => | <- ?]]
             [com.wsscode.async.async-cljs :refer [let-chan go-promise <!]]
             [com.wsscode.pathom.viz.request-history :as request-history]
-            [com.wsscode.pathom.viz.query-editor :as query.editor]
             [nubank.workspaces.card-types.fulcro3 :as ct.fulcro]
             [nubank.workspaces.core :as ws]
             [nubank.workspaces.model :as wsm]

diff --git a/src/cards/com/wsscode/pathom/viz/trace_cards.cljs b/src/cards/com/wsscode/pathom/viz/trace_cards.cljs
@@ -26,12 +26,12 @@
    ::pc/output [::color]
    ::pc/batch? true}
   (pc/batch-resolver
-    (fn [env {::keys [id]}]
+    (fn [_env {::keys [id]}]
       (go-catch
         (<? (async/timeout 300))
         {::color
          (get color-map id "black")}))
-    (fn [env ids]
+    (fn [_env ids]
       (go-catch
         (<? (async/timeout 300))
         (mapv
@@ -41,7 +41,7 @@
 (defresolver `weight
   {::pc/input  #{::id}
    ::pc/output [::weight ::size]}
-  (fn [env {::keys [id]}]
+  (fn [_env {::keys [id]}]
     (go-catch
       (<? (async/timeout 100))
       {::weight
@@ -61,7 +61,7 @@
 (defresolver `rel
   {::pc/input  #{::id}
    ::pc/output [::relation]}
-  (fn [env {::keys [id]}]
+  (fn [_env {::keys [id]}]
     (go-catch
       (<? (async/timeout 50))
       {::relation
@@ -74,27 +74,27 @@
 
 (defresolver `all
   {::pc/output [{::all [::id]}]}
-  (fn [env _]
+  (fn [_env _]
     {::all [{::id 1} {::id 2} {::id 3} {::id 2}]}))
 
 (defresolver `error
   {::pc/input  #{}
    ::pc/output [::error]}
-  (fn [env {::keys [id]}]
+  (fn [_env _]
     (throw (ex-info "Error" {:ex "data"}))))
 
 (defresolver `darken-color
   {::pc/input  #{::color}
    ::pc/output [::color-darken]}
-  (fn [env {::keys [color]}]
+  (fn [_env {::keys [color]}]
     (go-catch
       (<? (async/timeout 20))
       {::color-darken (str color "-darken")})))
 
 (defresolver `lighter-color
   {::pc/input  #{::color}
    ::pc/output [::color-lighter]}
-  (fn [env {::keys [color]}]
+  (fn [_env {::keys [color]}]
     (go-catch
       (<? (async/timeout 50))
       {::color-lighter (str color "-lighter")})))

diff --git a/src/cards/com/wsscode/pathom/viz/ui/kit_cards.cljs b/src/cards/com/wsscode/pathom/viz/ui/kit_cards.cljs
@@ -5,8 +5,7 @@
             [nubank.workspaces.model :as wsm]
             [com.wsscode.pathom.viz.ui.kit :as ui]
             [com.fulcrologic.fulcro-css.localized-dom :as dom]
-            [cljs.test :refer-macros [is are run-tests async testing]]
-            [cljs.spec.alpha :as s]))
+            [cljs.test :refer-macros [is are run-tests testing]]))
 
 (ws/deftest test-merge-with-mergers []
   (is (= (ui/merge-with-mergers {}

diff --git a/src/cards/com/wsscode/pathom/viz/workspaces_cards.cljs b/src/cards/com/wsscode/pathom/viz/workspaces_cards.cljs
@@ -1,9 +1,7 @@
 (ns com.wsscode.pathom.viz.workspaces-cards
   (:require [cljs.core.async :as async :refer [go <!]]
-            [com.wsscode.common.async-cljs :refer [<? go-catch]]
             [com.wsscode.pathom.connect :as pc]
             [com.wsscode.pathom.core :as p]
-            [nubank.workspaces.model :as wsm]
             [nubank.workspaces.core :as ws]
             [com.wsscode.pathom.viz.workspaces :as pvw]))
 

diff --git a/src/core/com/wsscode/pathom/viz/client.cljc b/src/core/com/wsscode/pathom/viz/client.cljc
@@ -1,7 +1,6 @@
 (ns com.wsscode.pathom.viz.client
   (:require [com.fulcrologic.guardrails.core :refer [>def >defn >fdef => | <- ?]]
-            [com.wsscode.socket-io.client :as sio-client]
-            [clojure.spec.alpha :as s]))
+            [com.wsscode.socket-io.client :as sio-client]))
 
 (>def ::parser fn?)
 

diff --git a/src/core/com/wsscode/pathom/viz/codemirror.cljs b/src/core/com/wsscode/pathom/viz/codemirror.cljs
@@ -1,6 +1,5 @@
 (ns com.wsscode.pathom.viz.codemirror
-  (:require [cljs.reader :refer [read-string]]
-            [cljs.spec.alpha :as s]
+  (:require [cljs.spec.alpha :as s]
             [cljsjs.codemirror]
             [clojure.string :as str]
             [com.wsscode.fuzzy :as fuzzy]
@@ -26,9 +25,7 @@
             ["parinfer-codemirror" :as parinfer-cm]
             ["./pathom-mode"]
             [com.wsscode.pathom3.connect.indexes :as pci]
-            [com.wsscode.pathom3.cache :as p.cache]
-            [clojure.set :as set]
-            [edn-query-language.core :as eql]))
+            [com.wsscode.pathom3.cache :as p.cache]))
 
 (s/def ::mode (s/or :string string? :obj map?))
 (s/def ::theme string?)
@@ -149,7 +146,7 @@
 
                           ; join: [{:child [|]}]
                           (and (= "join" mode)
-                               (= (string? key)))
+                               (string? key))
                           (let [key (str->keyword key)]
                             (if (contains? (get index-io #{}) key)
                               {:type :attribute :context (conj ctx key)}
@@ -244,7 +241,7 @@
          (fuzzy/fuzzy-match)
          (map ::fuzzy/string))))
 
-(defn autocomplete [index cm options]
+(defn autocomplete [index cm _options]
   (let [cur    (.getCursor cm)
         line   (.-line cur)
         ch     (.-ch cur)

diff --git a/src/core/com/wsscode/pathom/viz/codemirror6.cljs b/src/core/com/wsscode/pathom/viz/codemirror6.cljs
@@ -1,32 +1,32 @@
 (ns com.wsscode.pathom.viz.codemirror6
   (:require-macros [com.wsscode.pathom.viz.embed.macros :refer [defc]])
-  (:require ["@codemirror/closebrackets" :refer [closeBrackets]]
-            ["@codemirror/fold" :as fold]
-            ["@codemirror/gutter" :refer [lineNumbers]]
-            ["@codemirror/highlight" :as highlight]
-            ["@codemirror/history" :refer [history historyKeymap]]
-            ["@codemirror/state" :refer [EditorState]]
-            ["@codemirror/view" :as view :refer [EditorView]]
-            ["lezer" :as lezer]
-            ["lezer-generator" :as lg]
-            ["lezer-tree" :as lz-tree]
-            [applied-science.js-interop :as j]
-            [com.fulcrologic.guardrails.core :refer [<- => >def >defn >fdef ? |]]
-            [clojure.string :as str]
-            [nextjournal.clojure-mode :as cm-clj]
-            [nextjournal.clojure-mode.extensions.close-brackets :as close-brackets]
-            [nextjournal.clojure-mode.extensions.formatting :as format]
-            [nextjournal.clojure-mode.extensions.selection-history :as sel-history]
-            [nextjournal.clojure-mode.keymap :as keymap]
-            [nextjournal.clojure-mode.live-grammar :as live-grammar]
-            [nextjournal.clojure-mode.node :as n]
-            [nextjournal.clojure-mode.selections :as sel]
-            [nextjournal.clojure-mode.test-utils :as test-utils]
-            [helix.hooks :as hooks]
-            [helix.core :as h]
-            [com.fulcrologic.fulcro.dom :as dom]
-            [com.wsscode.pathom.viz.helpers :as pvh]
-            [clojure.walk :as walk]))
+  (:require
+    ;["@codemirror/closebrackets" :refer [closeBrackets]]
+    ["@codemirror/fold" :as fold]
+    ["@codemirror/gutter" :refer [lineNumbers]]
+    ["@codemirror/highlight" :as highlight]
+    ["@codemirror/history" :refer [history historyKeymap]]
+    ["@codemirror/state" :refer [EditorState]]
+    ["@codemirror/view" :as view :refer [EditorView]]
+    ; ["lezer" :as lezer]
+    ; ["lezer-generator" :as lg]
+    ; ["lezer-tree" :as lz-tree]
+    [applied-science.js-interop :as j]
+    [com.fulcrologic.guardrails.core :refer [<- => >def >defn >fdef ? |]]
+    [nextjournal.clojure-mode :as cm-clj]
+    ;[nextjournal.clojure-mode.extensions.close-brackets :as close-brackets]
+    ;[nextjournal.clojure-mode.extensions.formatting :as format]
+    ;[nextjournal.clojure-mode.extensions.selection-history :as sel-history]
+    ;[nextjournal.clojure-mode.keymap :as keymap]
+    ;[nextjournal.clojure-mode.live-grammar :as live-grammar]
+    ;[nextjournal.clojure-mode.node :as n]
+    ;[nextjournal.clojure-mode.selections :as sel]
+    ;[nextjournal.clojure-mode.test-utils :as test-utils]
+    [helix.hooks :as hooks]
+    [helix.core :as h]
+    [com.fulcrologic.fulcro.dom :as dom]
+    [com.wsscode.pathom.viz.helpers :as pvh]
+    [clojure.walk :as walk]))
 
 (def theme
   (.theme EditorView