Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting the widget #13

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

starting the widget #13

wants to merge 3 commits into from

Conversation

MayaGans
Copy link
Collaborator

Just a draft but I'm gonna try to turn this into an html widget so you can insert it into a markdown :)

@MayaGans MayaGans marked this pull request as draft November 10, 2020 20:11
@willdebras
Copy link
Owner

Awesome this is amazing! Since it's been on my mind, I'm going to work on playing with viewbox and making different sized base svgs, so the sizing could change for different uses, e.g. a little babey one in the viewer window or a medium sized or a medium sized one for a xaringan slide, etc.

@willdebras
Copy link
Owner

I'll leave open since it's in drafts.

@MayaGans
Copy link
Collaborator Author

I think htmlwidgets puts all your stuff in a div which resizes with the browser so we'd just have to scale the viewbox to the div? I don't know yet this is all uncharted territory lol

@MayaGans
Copy link
Collaborator Author

Ill undraft and ask for a review when I think it's ready for you.... right now it doesn't display anything 🙈

@MayaGans
Copy link
Collaborator Author

Okay @willdebras it renders!! I'm trying to make sense of this chapter which makes use of the render function in R which I added https://book.javascript-for-r.com/widgets-adv.html but we might also need to add some resize logic here feel free to pull this and try it yourself! I don't think we should merge with master until we're done with this new keyboard function though - thoughts?

@MayaGans
Copy link
Collaborator Author

Right now this doesn't do anything in JS, just renders the svg btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants