Skip to content

feat: Create folders in files list (WPB-17272) #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 14, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Apr 29, 2025

TaskWPB-17272 [Android] Create a folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Create folders

  • Show folders in conversation files

  • I have added automated test to this contribution

Attachments (Optional)

Screen_recording_20250512_154316.webm

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@ohassine ohassine changed the title feat: Show folder in files list feat: Show folder in files list (WPB-17392) Apr 29, 2025
@ohassine ohassine changed the title feat: Show folder in files list (WPB-17392) feat: Show folders in files list (WPB-17392) Apr 29, 2025
…-attachement-type

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreen.kt
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/download/DownloadFileBottomSheet.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt
#	kalium
@ohassine ohassine requested review from a team, typfel, sbakhtiarov, yamilmedina, saleniuk, mathias-niboulies and MohamadJaara and removed request for a team, typfel and mathias-niboulies May 7, 2025 16:40
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.00%. Comparing base (582145a) to head (5069473).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4007   +/-   ##
========================================
  Coverage    46.00%   46.00%           
========================================
  Files          520      520           
  Lines        18124    18124           
  Branches      3053     3053           
========================================
  Hits          8338     8338           
  Misses        8921     8921           
  Partials       865      865           
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...ions/model/messagetypes/asset/AssetMessageTypes.kt 0.00% <ø> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582145a...5069473. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4007.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4007.apk is available for download

@ohassine ohassine changed the title feat: Show folders in files list (WPB-17392) feat: Create folders in files list (WPB-17272) May 12, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-4007.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4007.apk is available for download

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀 Just small comments about todos and arguments

@ohassine ohassine requested a review from Garzas May 13, 2025 13:49
Copy link

@ohassine ohassine added this pull request to the merge queue May 14, 2025
Merged via the queue into develop with commit 49ddbae May 14, 2025
17 of 18 checks passed
@ohassine ohassine deleted the add-folder-type-as-attachement-type branch May 14, 2025 08:58
Copy link
Contributor

Built wire-android-staging-compat-pr-4007.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4007.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants