-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Create folders in files list (WPB-17272) #4007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
…-attachement-type # Conflicts: # kalium
…-attachement-type # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreen.kt
# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/download/DownloadFileBottomSheet.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4007 +/- ##
========================================
Coverage 46.00% 46.00%
========================================
Files 520 520
Lines 18124 18124
Branches 3053 3053
========================================
Hits 8338 8338
Misses 8921 8921
Partials 865 865
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Built wire-android-staging-compat-pr-4007.apk is available for download |
Built wire-android-dev-debug-pr-4007.apk is available for download |
Built wire-android-staging-compat-pr-4007.apk is available for download |
Built wire-android-dev-debug-pr-4007.apk is available for download |
features/cells/src/main/java/com/wire/android/feature/cells/ui/model/BottomSheetAction.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🚀 Just small comments about todos and arguments
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Show resolved
Hide resolved
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Outdated
Show resolved
Hide resolved
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Outdated
Show resolved
Hide resolved
|
Built wire-android-staging-compat-pr-4007.apk is available for download |
Built wire-android-dev-debug-pr-4007.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Create folders
Show folders in conversation files
I have added automated test to this contribution
Attachments (Optional)
Screen_recording_20250512_154316.webm
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.