-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WT-13948 Deprecate rollback_reason API #11519
Conversation
Thanks for creating a pull request! Please answer the questions below by editing this comment. Type of change made in this PR
What makes this change safe?Answering this question helps the reviewers understand where they should focus their attention. Please consider these prompts:
References: Checklist before requesting a review
|
Test coverage is very low, please refer to the Code change/coverage report links below and try to improve it if feasible.
|
Running a full patch build to check that nothing else relies on |
I wouldn't deem this as high risk, maybe medium risk. High risk would refer to no testing can be done to ensure this is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice go at the deprecation, have a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Etienne Petrel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have two comments, can you also do a full wiredtiger patch build and once MongoDB has removed the usage of rollback_reason to also do a full MongoDB patch build?
Hi @lukech, for context we thought it'd be worth adding you as a reviewer to this PR since it involves deprecating a feature that could potentially have wider consequences for Mongo or any other customers currently relying on it. |
@LX6T thanks for the useful context. I'm not aware of any application/customer other than Mongo server that makes use of this rollback reason API. Just to confirm you won't merge this PR until after Mongo Server removes the usage of this API, right? Normally, API interface changes need to update the |
…or API instead of get_rollback_reason
Thanks for the response @lukech, I can confirm that we won't merge this until |
After milestone 2 and [WT-13947](https://jira.mongodb.org/browse/WT-13947) all rollback reason messages should have been covered by the get_last_error API. This ticket involves deprecating the rollback reason API. In this case, we should be changing all existing rollback_reason related tests to use the get_last_error API. --------- Co-authored-by: Etienne Petrel <[email protected]>
After milestone 2 and [WT-13947](https://jira.mongodb.org/browse/WT-13947) all rollback reason messages should have been covered by the get_last_error API. This ticket involves deprecating the rollback reason API. In this case, we should be changing all existing rollback_reason related tests to use the get_last_error API. Original PR: #11519 (Creating PR to get ready for merge, will need to wait for public mongo repo to sync to 10gen repo) --------- Co-authored-by: Alex Pullen <[email protected]> Co-authored-by: Alex Pullen <[email protected]> Co-authored-by: Etienne Petrel <[email protected]>
After milestone 2 and [WT-13947](https://jira.mongodb.org/browse/WT-13947) all rollback reason messages should have been covered by the get_last_error API. This ticket involves deprecating the rollback reason API. In this case, we should be changing all existing rollback_reason related tests to use the get_last_error API. Original PR: #11519 I have created a manual patch that adds the required changes for many-collection-test to not break. We will need to remove this once copybara is back on sync. --------- Co-authored-by: Alex Pullen <[email protected]> Co-authored-by: Alex Pullen <[email protected]> Co-authored-by: Etienne Petrel <[email protected]>
After milestone 2 and WT-13947 all rollback reason messages should have been covered by the get_last_error API. This ticket involves deprecating the rollback reason API. In this case, we should be changing all existing rollback_reason related tests to use the get_last_error API.