Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lgbm): support string features via pandas categorical #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aywandji
Copy link

add logic to convert string features to int (using lightgbm model pandas categoricals) before prediction

@aywandji aywandji marked this pull request as ready for review March 14, 2022 11:36
@aywandji aywandji requested a review from cp2587 March 14, 2022 11:36
@aywandji aywandji force-pushed the support-string-features-gbm branch from 9ea0ead to 737794b Compare March 15, 2022 10:28
@aywandji aywandji force-pushed the support-string-features-gbm branch from 737794b to 7e07e25 Compare March 31, 2022 10:07
@aywandji aywandji force-pushed the support-string-features-gbm branch from 7e07e25 to 12d4677 Compare March 31, 2022 10:17
@cp2587
Copy link
Contributor

cp2587 commented Apr 1, 2022

I let @crqs merge this as he recently worked on this project to make sure the inference performances were good enough: i want him to know of this so he can backtrack if performance deteriorate.

also as discussed, we should see if the python code and loop can be replaces by something else as it has maybe an huge impact on inference times

@cp2587 cp2587 requested a review from crqs April 1, 2022 08:34
@cp2587 cp2587 assigned crqs and unassigned cp2587 Apr 1, 2022
@aywandji aywandji assigned aywandji and unassigned crqs Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants