-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow integrations to change the base for server-islands URLs #12320
feat: Allow integrations to change the base for server-islands URLs #12320
Conversation
🦋 Changeset detectedLatest commit: e4d732d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If you're looking for feedback, please make the PR a draft. As you said, the PR isn't meant to be ready because tests are missing. Also, regardless of the entity of the feature, docs must be provided to the user. |
11b5101
to
8d4025b
Compare
8d4025b
to
820e064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a patch but a minor
. I am going to block it to avoid accidental merges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
This has moved to https://github.com/withastro/astro/pull/12560/files |
See proposal withastro/roadmap#1043 to see the full reasoning behind this change.
This PR only contains the required changes to enable an integration to be built. However, I created a draft PR that shows an integration and the example that uses it #12304. Please look at that PR to see the full desired impact of this change.
Changes
With config:

Result:

Testing
A manual test has been run in the separate PR. No automated tests have been added.
I have added an test that ensures that the build output contains the base URL that we specify.
Docs
Docs are added in withastro/docs#10106 that explain to integration authors this new config option.