Skip to content

Update README and add a summary of translation progress #11495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2025

Conversation

delucis
Copy link
Member

@delucis delucis commented Apr 20, 2025

Description (required)

  • Generates a summary.svg file as part of Lunaria builds that shows progress for each locale.
  • Adds this with a link to our Lunaria dashboard to the README.

Notes

  • To support reasonable display on both light and dark backgrounds, this uses a somewhat muted grey text colour. This colour has roughly a 10:1 contrast ratio against both black and white.
  • On mobile screens the text will appear slightly small, but I tried to strike a balance between a decent display on desktop and mobile.
  • We only build Lunaria on main so can’t really preview this PR but here are a few examples:
Example output
a grid of language entries each showing a language’s name, the number of completed, outdated, and missing translations, and a progress bar representing the same
Example in context in README.md
the same image as above but now embedded in the docs README with a “Translation progress” heading above it

Copy link

netlify bot commented Apr 20, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit d0dc126
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/680518741f35b8000831499d
😎 Deploy Preview https://deploy-preview-11495--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@delucis delucis marked this pull request as ready for review April 20, 2025 15:55
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks lovely!

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We could revisit with an image each for dark/light if we want more contrast for certain themes (https://github.blog/developer-skills/github/how-to-make-your-images-in-markdown-on-github-adjust-for-dark-mode-and-light-mode/#one-snippet-two-themes)

@delucis
Copy link
Member Author

delucis commented Apr 20, 2025

Thanks! Yeah, we can consider light/dark support in the future if we want.

@delucis delucis merged commit 80db20c into main Apr 20, 2025
10 checks passed
@delucis delucis deleted the chris/i18n-summary branch April 20, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants