Skip to content

Patch recyclerlistview #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Apr 9, 2025

Add patch for recyclerlistview with fix on VistualRenderer updateOffset() for RTL in RN73 and above

Yarn 3.4.1 (min 2 is required)

Ticket 4668

@Inbal-Tish Inbal-Tish requested a review from Copilot April 9, 2025 05:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@ethanshar
Copy link
Contributor

@Inbal-Tish
There's not much to review here, do you know why the pathed file is empty? Doesn't it suppose to have the fixed code of the file or something?
I wonder if will work when installed in another package, can we create a temp version to test in uilib?

@ethanshar ethanshar assigned Inbal-Tish and unassigned ethanshar Apr 14, 2025
@Inbal-Tish Inbal-Tish assigned ethanshar and unassigned Inbal-Tish Apr 24, 2025
@Inbal-Tish
Copy link
Collaborator Author

@Inbal-Tish There's not much to review here, do you know why the pathed file is empty? Doesn't it suppose to have the fixed code of the file or something? I wonder if will work when installed in another package, can we create a temp version to test in uilib?

Fixed. I parched the dist file instead

@Inbal-Tish Inbal-Tish requested review from yuvalsho and removed request for ethanshar April 24, 2025 11:58
@Inbal-Tish Inbal-Tish assigned yuvalsho and unassigned ethanshar Apr 24, 2025
@Inbal-Tish Inbal-Tish requested a review from Copilot April 24, 2025 12:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .yarn/patches/recyclerlistview-npm-4.2.1-ff4e0c8a07.patch: Language not supported
  • package.json: Language not supported

@Inbal-Tish Inbal-Tish assigned Inbal-Tish and unassigned yuvalsho May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants