forked from armooo/pytivo
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge a mobile web interface with your mainstream pytivo fork? #2
Open
wynneth
wants to merge
27
commits into
wmcbrine:master
Choose a base branch
from
wynneth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig page is non-mobile
…reated that was adding Format= string where it shouldn't and causing tivo to fail displaying more than first page of items in video shares.
Merged all the guts with wmcbrine's, simply leaving the modification to the ui/mobile browser interface intact here. Removed the dvdvideo plugin entirely, simply due to lack of personal use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked your project and basically modified what the lucasnz fork was trying to do as far as mobile formatting of the web interface for smartphone access. It's all your most current code as of this message, just with the addition of the user agent selection to direct mobile browsers to a more streamlined UI. I haven't made any changes to the "Web Configuration" page, because frankly besides how much information is there I don't feel is appropriate to a mobile interface, but have so far left the link for it in the mobile UI. I'd welcome any input, whether or not you would like to pull in my changes.
Thanks for maintaining a great project
Bruce