Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dresden.json #62

Closed

Conversation

RobTranquillo
Copy link
Contributor

No description provided.

@johnjohndoe
Copy link
Member

You are missing the changes in the README.md. Please have a look at the contribution guide.

@RobTranquillo
Copy link
Contributor Author

Uh, Iam sorry...
Updated the readme.

@dirkschumacher
Copy link
Member

There is one point in Mittweida which seems to be quite far away from Dresden.

},
"properties": {
"location": "Markt in Dresden Hellerau",
"opening_hours": "Fr 09-16:00",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time format is not correct here. Should be Fr 09:00-16:00.
Please update the commit using git commit --fixup=d3ee6b followed by git rebase -i --autosquash master. Then update this branch via git push --force origin market-data-dresden.

@johnjohndoe
Copy link
Member

johnjohndoe commented Apr 22, 2016

@RobTranquillo Thanks for the corrections. I would like you to put the three "fixup" commits into the initial commit and then update your branch. This can be done as follows:

git checkout market-data-dresden
git rebase --interactive bebadd

In the editor replace pick with fixup for the three fixup commits (bottom is the latest).

pick d3ee6bb add Dresden json
fixup 6df9db3 add Dresden to supported cities in readme
fixup 6ae21b2 fix one location and one opening hour
fixup 1b518f4 fix of the fix (tab to spaces)

Then you save and leave the editor. Afterwards, one commit should remain on the branch which contains all your changes. Now you can overwrite the branch on GitHub:

git push --force origin market-data-dresden

Finally, it is a good idea to rebase the branch onto the latest commit on master (as described in the contribution guide). This will ensure, there are no conflicts with commits which have been done on master since you branched off with market-data-dresden. Here is what you can do:

First, update the master branch on your machine and on your GitHub clone:

git checkout master
git pull wo-ist-markt master
git push origin master

Then rebase your branch onto master and update it on GitHub once again:

git rebase master market-data-dresden
git push --force origin market-data-dresden

This will automatically update the pull request since the branch name stayed the same.


As always, I will answer questions in case your have any.

@johnjohndoe
Copy link
Member

Something went wrong. I fixed the branch on my local copy and merged it into master. You can throw away your local branch and the corresponding branch on your GitHub clone now.

To sum it up: Welcome on the map 🎉
Please have a look at #38.

@johnjohndoe johnjohndoe self-assigned this Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants