-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dresden.json #62
add dresden.json #62
Conversation
You are missing the changes in the README.md. Please have a look at the contribution guide. |
Uh, Iam sorry... |
There is one point in Mittweida which seems to be quite far away from Dresden. |
}, | ||
"properties": { | ||
"location": "Markt in Dresden Hellerau", | ||
"opening_hours": "Fr 09-16:00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time format is not correct here. Should be Fr 09:00-16:00
.
Please update the commit using git commit --fixup=d3ee6b
followed by git rebase -i --autosquash master
. Then update this branch via git push --force origin market-data-dresden
.
@RobTranquillo Thanks for the corrections. I would like you to put the three "fixup" commits into the initial commit and then update your branch. This can be done as follows: git checkout market-data-dresden
git rebase --interactive bebadd In the editor replace
Then you save and leave the editor. Afterwards, one commit should remain on the branch which contains all your changes. Now you can overwrite the branch on GitHub: git push --force origin market-data-dresden Finally, it is a good idea to First, update the git checkout master
git pull wo-ist-markt master
git push origin master Then git rebase master market-data-dresden
git push --force origin market-data-dresden This will automatically update the pull request since the branch name stayed the same. As always, I will answer questions in case your have any. |
1b518f4
to
a76e009
Compare
a76e009
to
2b55e59
Compare
Something went wrong. I fixed the branch on my local copy and merged it into To sum it up: Welcome on the map 🎉 |
No description provided.