feat: add gpio_list method to retrieve all GPIO pins in WokwiClient #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urish
reviewed
Aug 20, 2025
src/wokwi_client/client.py
Outdated
| @@ -222,6 +251,10 @@ async def listen_pin(self, part: str, pin: str, listen: bool = True) -> Response | |||
| """ | |||
| return await pin_listen(self._transport, part=part, pin=pin, listen=listen) | |||
|
|
|||
| async def gpio_list(self) -> ResponseMessage: | |||
There was a problem hiding this comment.
Let's return a useful type (ResponseMessage isn't really useful for someone who is using the API.
IMHO the client should check for error, and throw if there's one, otherwise just return the result with a proper type (so users know which fields to expect and what types they have)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to list all GPIO pins available in the simulation. The main update is the introduction of a new method to the client and its supporting implementation.