Refactor of ECDSA sign module, SEC1 support for ECDSA, PKCS1 for RSA-PSS and PKCS8 for RSAPKCS1 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gasbytes
commented
Feb 14, 2025
•
gasbytes
commented
- Refactored the ECDSA sign module to improve code clarity;
- Added SEC1 support for ECDSA keys;
- PKCS1 for RSA-PSS;
- PKCS8 for RSAPKCS1;
- Merged P-256, P-384, and P-521 structs into a single `EcdsaSigningKey` - Determined `SignatureScheme` based on key size instead of WolfSSL curve ID - Simplified signing logic and reduced duplicate code Prepares for SEC1 support in future commits.
- Merged separate P-256, P-384, and P-521 verifiers into a single `EcdsaVerifier` - Determined curve, hash function, and public key parsing based on `SignatureScheme` - Reduced code duplication while maintaining the same logic and comments No changes to external API; existing mappings in `verify.rs` remain unchanged.
single module called rsa.rs to better handle the different private key formats (with matching via SignatureScheme); - Completed support for PKCS8 for RSA-PKCS1 and PKCS1 for RSA-PSS;
gasbytes
force-pushed
the
pkcs1-and-sec1-support
branch
from
bce6498 to
e96ab68
Compare
JacobBarthelmeh
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.