-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add POSIX demo runner script and CI integration #19
Open
devin-ai-integration
wants to merge
123
commits into
main
Choose a base branch
from
devin/1739903237-add-posix-demo-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add POSIX demo runner script and CI integration #19
devin-ai-integration
wants to merge
123
commits into
main
from
devin/1739903237-add-posix-demo-script
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Adds run_posix_demo.sh to automate demo execution - Integrates script into CI workflow - Handles build, execution and cleanup properly Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove redundant CI steps in favor of demo script - Fix double server start in script - Add better documentation for example usage Co-Authored-By: [email protected] <[email protected]>
- Add script usage to README - Add detailed script documentation - Document environment variables and exit codes Co-Authored-By: [email protected] <[email protected]>
The server needs more time to initialize in CI environment. Co-Authored-By: [email protected] <[email protected]>
Show server output while waiting for it to start up to help diagnose startup issues. Co-Authored-By: [email protected] <[email protected]>
Display server log contents when server fails to start to help diagnose startup issues. Co-Authored-By: [email protected] <[email protected]>
- Create log file before starting server - Use tee to capture output in real-time - Check for initialization errors immediately Co-Authored-By: [email protected] <[email protected]>
Use standard output redirection and add small delay to ensure initial output is captured. Co-Authored-By: [email protected] <[email protected]>
- Add absolute path handling for server binary - Check server binary exists and is executable - Add more verbose server output Co-Authored-By: [email protected] <[email protected]>
- Add more server startup messages to detect - Show server output while waiting for startup - Add 'Error:' to initialization error detection Co-Authored-By: [email protected] <[email protected]>
- Add specific wolfCrypt and RNG initialization error checks - Simplify server ready detection to single message - Show full server output during startup Co-Authored-By: [email protected] <[email protected]>
- Add environment variable checks with helpful messages - Increase timeout for wolfCrypt initialization - Add better error detection during startup - Show full server log on startup failure Co-Authored-By: [email protected] <[email protected]>
- Use absolute paths for wolfSSL and wolfHSM directories - Make demo script executable in CI Co-Authored-By: [email protected] <[email protected]>
- Build wolfSSL with all features enabled - Build wolfHSM with wolfSSL integration - Keep environment variables pointing to built libraries Co-Authored-By: [email protected] <[email protected]>
- Install autoconf, automake, and libtool - Remove -j flag for more stable builds - Keep wolfSSL and wolfHSM build steps Co-Authored-By: [email protected] <[email protected]>
- Install build dependencies before building wolfSSL - Enable specific wolfSSL features needed by wolfHSM - Enable debug mode for wolfHSM Co-Authored-By: [email protected] <[email protected]>
- Install wolfSSL with debug enabled - Install wolfHSM with debug enabled - Run ldconfig to update library cache Co-Authored-By: [email protected] <[email protected]>
Required for wolfSSL and wolfHSM configuration Co-Authored-By: [email protected] <[email protected]>
- Enable hardening in wolfSSL - Set PKG_CONFIG_PATH for wolfHSM - Enable examples in wolfHSM build Co-Authored-By: [email protected] <[email protected]>
- Add build-essential package - Enable wolfSSL debug output with CFLAGS Co-Authored-By: [email protected] <[email protected]>
- Add DEBUG_WOLFSSL flag for more verbose output - Enable shared library build for wolfSSL - Add .libs path to LDFLAGS for wolfHSM Co-Authored-By: [email protected] <[email protected]>
- Remove unnecessary wolfSSL features - Simplify build flags to essentials - Keep debug and shared library support Co-Authored-By: [email protected] <[email protected]>
Re-enable required features for wolfHSM: - keygen - certgen - certreq - certext - pkcs7 Co-Authored-By: [email protected] <[email protected]>
Add --enable-rng flag to ensure RNG functionality is available Co-Authored-By: [email protected] <[email protected]>
Enable all features to ensure all required functionality is available Co-Authored-By: [email protected] <[email protected]>
- Enable static library builds for wolfSSL and wolfHSM - Add descriptive comments for build steps - Keep all required features enabled Co-Authored-By: [email protected] <[email protected]>
Remove potentially conflicting --enable-all flag while keeping specific required features Co-Authored-By: [email protected] <[email protected]>
- Use absolute paths for server binary - Ensure correct working directory - Create log directory before starting server Co-Authored-By: [email protected] <[email protected]>
- Use PWD to get absolute paths for wolfssl and wolfhsm - Add debug output for working directory Co-Authored-By: [email protected] <[email protected]>
- Add debug output for binary locations - Make server and client binaries executable - Show directory contents for debugging Co-Authored-By: [email protected] <[email protected]>
- Change to repo root first - Add immediate log output for debugging - Keep server log in server directory Co-Authored-By: [email protected] <[email protected]>
- Create Build directory before starting server - Place log file in Build directory for consistency Co-Authored-By: [email protected] <[email protected]>
- Use LOG_FILE variable consistently throughout script - Simplify log file path handling Co-Authored-By: [email protected] <[email protected]>
- Replace all instances of ./server.log with LOG_FILE - Ensure consistent log file handling in all error cases Co-Authored-By: [email protected] <[email protected]>
- Remove tail -f which might interfere with server - Add immediate server process check - Show server log if process fails to start Co-Authored-By: [email protected] <[email protected]>
- Use strace to debug server startup - Show server working directory - Print initial server output Co-Authored-By: [email protected] <[email protected]>
- Show server binary permissions - Check server binary dependencies - Remove strace (may not be available) Co-Authored-By: [email protected] <[email protected]>
- Show environment variables - Display process info after start - Add more detailed server status checks Co-Authored-By: [email protected] <[email protected]>
- Add LD_DEBUG for library loading issues - Show server command being run - Show server working directory - Add more process info Co-Authored-By: [email protected] <[email protected]>
- Remove LD_DEBUG which may interfere with server - Show server environment before start - Show initial server output immediately - Improve log file handling Co-Authored-By: [email protected] <[email protected]>
- Create log file before starting server - Set proper permissions on log file - Improve log file handling Co-Authored-By: [email protected] <[email protected]>
- Add --debug flag to server for more verbose output - Increase startup wait time to 5 seconds - Keep log file permissions fix Co-Authored-By: [email protected] <[email protected]>
- Remove --debug flag (not supported) - Add immediate server output check - Reduce wait time to 2 seconds Co-Authored-By: [email protected] <[email protected]>
- Show server binary permissions before start - Add explicit server process check - Improve error handling Co-Authored-By: [email protected] <[email protected]>
- Create keys directory for server storage - Change to server directory before starting - Add more detailed working directory info - Return to original directory after start Co-Authored-By: [email protected] <[email protected]>
- Use consistent variable for server directory - Create data directory in server's directory - Improve directory handling Co-Authored-By: [email protected] <[email protected]>
- Add strace to debug server startup - Set proper permissions on server and data dir - Add more detailed logging Co-Authored-By: [email protected] <[email protected]>
- Remove strace (not available in CI) - Reduce wait time to 2 seconds - Show data directory contents Co-Authored-By: [email protected] <[email protected]>
- Set LD_LIBRARY_PATH to include wolfSSL and wolfHSM - Clean up server log before starting - Improve directory handling Co-Authored-By: [email protected] <[email protected]>
- Add LD_DEBUG for library loading info - Show ldd output for binary dependencies - Increase startup wait time Co-Authored-By: [email protected] <[email protected]>
- Check for required wolfSSL and wolfHSM libraries - Show library directory contents if missing - Update library path to use lib subdirectories Co-Authored-By: [email protected] <[email protected]>
- Use find to locate library files - Use actual library directories for LD_LIBRARY_PATH - Add more detailed library path logging Co-Authored-By: [email protected] <[email protected]>
- Use top-level directories for library path - Remove unnecessary directory resolution - Improve library path debugging Co-Authored-By: [email protected] <[email protected]>
- Use .libs directory for library paths - Update LD_LIBRARY_PATH to point to correct library locations Co-Authored-By: [email protected] <[email protected]>
- Configure and build wolfSSL with shared libraries - Configure and build wolfHSM with shared libraries - Update library paths for demo script Co-Authored-By: [email protected] <[email protected]>
- Run autogen.sh before configure - Add LD_LIBRARY_PATH to demo script - Update library paths for shared libraries Co-Authored-By: [email protected] <[email protected]>
- Set explicit prefix for wolfSSL and wolfHSM - Update wolfHSM to use installed wolfSSL location Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to automate running the POSIX TCP demo examples and integrates it into CI.
The script:
Changes:
Testing:
Link to Devin run: https://app.devin.ai/sessions/f463619efe6f4276b05b0be8f1fa67f4