Skip to content

Commit

Permalink
Aarch64 CPU id: fix for privilege instruction detection
Browse files Browse the repository at this point in the history
AES/PMULL is in four bits 4-7.
When value is 0b0010, this indicates both AES and PMULL. Fix code to set
both.
  • Loading branch information
SparkiDev committed Dec 23, 2024
1 parent 2bcad98 commit e7d7e47
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions wolfcrypt/src/cpuid.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
#elif defined(HAVE_CPUID_AARCH64)

#define CPUID_AARCH64_FEAT_AES ((word64)1 << 4)
#define CPUID_AARCH64_FEAT_PMULL ((word64)1 << 5)
#define CPUID_AARCH64_FEAT_AES_PMULL ((word64)1 << 5)
#define CPUID_AARCH64_FEAT_SHA256 ((word64)1 << 12)
#define CPUID_AARCH64_FEAT_SHA256_512 ((word64)1 << 13)
#define CPUID_AARCH64_FEAT_RDM ((word64)1 << 28)
Expand All @@ -131,8 +131,10 @@

if (features & CPUID_AARCH64_FEAT_AES)
cpuid_flags |= CPUID_AES;
if (features & CPUID_AARCH64_FEAT_PMULL)
if (features & CPUID_AARCH64_FEAT_AES_PMULL) {
cpuid_flags |= CPUID_AES;
cpuid_flags |= CPUID_PMULL;
}
if (features & CPUID_AARCH64_FEAT_SHA256)
cpuid_flags |= CPUID_SHA256;
if (features & CPUID_AARCH64_FEAT_SHA256_512)
Expand Down Expand Up @@ -279,7 +281,6 @@
void cpuid_set_flags(void)
{
if (!cpuid_check) {

#ifndef WOLFSSL_ARMASM_NO_HW_CRYPTO
cpuid_flags |= CPUID_AES;
cpuid_flags |= CPUID_PMULL;
Expand All @@ -300,6 +301,7 @@
#ifdef WOLFSSL_ARMASM_CRYPTO_SM4
cpuid_flags |= CPUID_SM4;
#endif

cpuid_check = 1;
}
}
Expand Down

0 comments on commit e7d7e47

Please sign in to comment.